linux-api.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: David Drysdale <drysdale@google.com>,
	linux-api@vger.kernel.org,
	Michael Kerrisk <mtk.manpages@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Shuah Khan <shuahkh@osg.samsung.com>,
	Jonathan Corbet <corbet@lwn.net>,
	Eric B Munson <emunson@akamai.com>,
	Randy Dunlap <rdunlap@infradead.org>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	Oleg Nesterov <oleg@redhat.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andy Lutomirski <luto@amacapital.net>,
	Al Viro <viro@zeniv.linux.org.uk>,
	Rusty Russell <rusty@rustcorp.com.au>,
	Peter Zijlstra <peterz@infradead.org>,
	Vivek Goyal <vgoyal@redhat.com>,
	Alexei Starovoitov <ast@plumgrid.com>,
	David Herrmann <dh.herrmann@gmail.com>,
	Theodore Ts'o <tytso@mit.edu>, Kees Cook <keescook@chromium>
Subject: Re: [PATCHv2 1/1] Documentation: describe how to add a system call
Date: Thu, 30 Jul 2015 09:45:23 -0700	[thread overview]
Message-ID: <20150730164523.GA5364@kroah.com> (raw)
In-Reply-To: <20150730163007.GA10522@rei.suse.de>

On Thu, Jul 30, 2015 at 06:30:07PM +0200, Cyril Hrubis wrote:
> Hi!
> > +Testing
> > +-------
> > +
> > +A new system call should obviously be tested; it is also useful to provide
> > +reviewers with a demonstration of how user space programs will use the system
> > +call.  A good way to combine these aims is to include a simple self-test
> > +program in a new directory under tools/testing/selftests/.
> 
> I know that this is a bit off topic, but since the selftest is now the
> official place to add kernel testcases to let me rant about it a bit.
> 
> It's a bit of a pain seeing people reinvent the wheel and trying to
> figure out consistent test interface while most of the problems has been
> solved in LTP[1] test library quite some time ago. Especially use of the
> SAFE_MACROS[2] would simplify writing test setups quite a lot.
> 
> I wonder if we can at least share the test library, pulling it out of
> LTP, or at least the interesting parts, wouldn't be hard at all.
> 
> [1]
> https://github.com/linux-test-project/ltp/wiki/Test-Writing-Guidelines#221-basic-test-structure
> 
> [2]
> https://github.com/linux-test-project/ltp/wiki/Test-Writing-Guidelines#224-safe-macros

That would be great, please send patches to do so to the linux-api
mailing list and the test maintainer.

thanks,

greg k-h

  reply	other threads:[~2015-07-30 16:45 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-30  7:52 [PATCHv2 0/1] Document how to add a new syscall David Drysdale
2015-07-30  7:52 ` [PATCHv2 1/1] Documentation: describe how to add a system call David Drysdale
2015-07-30  8:38   ` Ingo Molnar
     [not found]     ` <20150730083831.GA22182-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-07-30 11:10       ` David Drysdale
2015-07-30 18:21         ` Kees Cook
     [not found]           ` <CAGXu5j+5KHy68ELU6PmNWaj7mQBXTbRQGXqJFwsXHt9n0LPw8Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-07-30 19:04             ` Josh Triplett
2015-07-30 20:03               ` Kees Cook
2015-07-31  1:02                 ` Josh Triplett
2015-07-31  1:03                   ` Josh Triplett
2015-07-31 18:56                   ` Kees Cook
2015-07-31 20:59                     ` josh
2015-07-31 21:19                       ` Andy Lutomirski
     [not found]                         ` <CALCETrUkMXvFRKdTH7ekY7FyGvbKDDJbf7L0shgs5R-Hep6bVA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-07-31 22:08                           ` josh-iaAMLnmF4UmaiuxdJuQwMA
2015-07-31 22:54                             ` Andy Lutomirski
2015-08-01  4:32                               ` Josh Triplett
2015-08-01  4:56                                 ` H. Peter Anvin
     [not found]                                   ` <55BC518E.4010102-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
2015-08-01  6:18                                     ` Josh Triplett
2015-08-01  6:28                                       ` H. Peter Anvin
2015-07-30 18:22     ` Josh Triplett
2015-07-30 16:30   ` Cyril Hrubis
2015-07-30 16:45     ` Greg Kroah-Hartman [this message]
2015-07-30 18:50   ` Josh Triplett
2015-07-31  9:48     ` David Drysdale
2015-07-31 13:06       ` Josh Triplett
2015-07-31 14:42         ` David Drysdale

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150730164523.GA5364@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=ast@plumgrid.com \
    --cc=chrubis@suse.cz \
    --cc=corbet@lwn.net \
    --cc=dh.herrmann@gmail.com \
    --cc=drysdale@google.com \
    --cc=emunson@akamai.com \
    --cc=hpa@zytor.com \
    --cc=keescook@chromium \
    --cc=linux-api@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=mingo@redhat.com \
    --cc=mtk.manpages@gmail.com \
    --cc=oleg@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rdunlap@infradead.org \
    --cc=rusty@rustcorp.com.au \
    --cc=shuahkh@osg.samsung.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=tytso@mit.edu \
    --cc=vgoyal@redhat.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).