linux-api.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: David Herrmann <dh.herrmann@gmail.com>,
	Shuah Khan <shuahkh@osg.samsung.com>,
	linux-api@vger.kernel.org, linux-kernel@vger.kernel.org,
	Daniel Mack <daniel@zonque.org>,
	Djalal Harouni <tixxdz@opendz.org>
Subject: Re: [PATCH] kdbus/samples: skip on CROSS_COMPILE
Date: Thu, 30 Jul 2015 13:00:18 -0400	[thread overview]
Message-ID: <20150730170018.GH18685@windriver.com> (raw)
In-Reply-To: <20150730163307.GA20048@kroah.com>

[Re: [PATCH] kdbus/samples: skip on CROSS_COMPILE] On 30/07/2015 (Thu 09:33) Greg Kroah-Hartman wrote:

> On Thu, Jul 30, 2015 at 06:13:25PM +0200, David Herrmann wrote:
> > Apparently we cannot rely on up-to-date kernel headers to be available
> > when cross-compiling, not even for HOSTCC. That's sad, but it's how it
> > is. Skip samples on cross-compiles as suggested by Paul, so allmodconfig
> > runs smoothly again.
> > 
> > Tested-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> > Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
> > ---
> >  samples/kdbus/Makefile | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/samples/kdbus/Makefile b/samples/kdbus/Makefile
> > index 137f842..dbd9de8 100644
> > --- a/samples/kdbus/Makefile
> > +++ b/samples/kdbus/Makefile
> > @@ -1,9 +1,13 @@
> >  # kbuild trick to avoid linker error. Can be omitted if a module is built.
> >  obj- := dummy.o
> >  
> > +ifndef CROSS_COMPILE
> 
> This really feels like the wrong solution.
> 
> > +
> >  hostprogs-$(CONFIG_SAMPLE_KDBUS) += kdbus-workers
> >  
> >  always := $(hostprogs-y)
> >  
> >  HOSTCFLAGS_kdbus-workers.o += -I$(objtree)/usr/include
> >  HOSTLOADLIBES_kdbus-workers := -lrt
> > +
> > +endif
> 
> Shuah, how should we fix this "properly"?  How is this resolved for the
> kernel test scripts, it should have the same issue that the samples do.

If you guys want to reproduce it, in order to figure out what mips does
with its headers that no other arch does, it should be as simple as:

wget https://www.kernel.org/pub/tools/crosstool/files/bin/x86_64/4.6.3/x86_64-gcc-4.6.3-nolibc_mips-linux.tar.xz

<untar somewhere>
<add resulting bin dir to your $PATH>

export CROSS_COMPILE=mips-linux-
export ARCH=mips

cd kernel-source
make allmodconfig
make -j16 samples/

Paul.
--

> 
> thanks,
> 
> greg k-h

  parent reply	other threads:[~2015-07-30 17:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1438272805-19029-1-git-send-email-dh.herrmann@gmail.com>
     [not found] ` <1438272805-19029-1-git-send-email-dh.herrmann-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-07-30 16:33   ` [PATCH] kdbus/samples: skip on CROSS_COMPILE Greg Kroah-Hartman
     [not found]     ` <20150730163307.GA20048-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2015-07-30 17:00       ` David Herrmann
2015-07-30 17:00     ` Paul Gortmaker [this message]
2015-07-31 14:28     ` Sudip Mukherjee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150730170018.GH18685@windriver.com \
    --to=paul.gortmaker@windriver.com \
    --cc=daniel@zonque.org \
    --cc=dh.herrmann@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shuahkh@osg.samsung.com \
    --cc=tixxdz@opendz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).