From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Rostedt Subject: Re: [RFC PATCH 09/14] ring_buffer: Initialize completions statically in the benchmark Date: Mon, 3 Aug 2015 14:31:09 -0400 Message-ID: <20150803143109.0b13925b@gandalf.local.home> References: <1438094371-8326-1-git-send-email-pmladek@suse.com> <1438094371-8326-10-git-send-email-pmladek@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1438094371-8326-10-git-send-email-pmladek@suse.com> Sender: owner-linux-mm@kvack.org To: Petr Mladek Cc: Andrew Morton , Oleg Nesterov , Tejun Heo , Ingo Molnar , Peter Zijlstra , "Paul E. McKenney" , Josh Triplett , Thomas Gleixner , Linus Torvalds , Jiri Kosina , Borislav Petkov , Michal Hocko , linux-mm@kvack.org, Vlastimil Babka , live-patching@vger.kernel.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-api@vger.kernel.org On Tue, 28 Jul 2015 16:39:26 +0200 Petr Mladek wrote: > It looks strange to initialize the completions repeatedly. > > This patch uses static initialization. It simplifies the code > and even helps to get rid of two memory barriers. There was a reason I did it this way and did not use static initializers. But I can't recall why I did that. :-/ I'll have to think about this some more. -- Steve -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org