From: Michal Hocko <mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Eric B Munson <emunson-JqFfY2XvxFXQT0dZR+AlfA@public.gmane.org>
Cc: Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
Vlastimil Babka <vbabka-AlSwsSmVLrQ@public.gmane.org>,
Jonathan Corbet <corbet-T1hC0tSOHrs@public.gmane.org>,
"Kirill A. Shutemov"
<kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v7 3/6] mm: Introduce VM_LOCKONFAULT
Date: Wed, 26 Aug 2015 09:20:16 +0200 [thread overview]
Message-ID: <20150826072016.GD25196@dhcp22.suse.cz> (raw)
In-Reply-To: <20150825190300.GG17005-JqFfY2XvxFXQT0dZR+AlfA@public.gmane.org>
On Tue 25-08-15 15:03:00, Eric B Munson wrote:
[...]
> Would you drop your objections to the VMA flag if I drop the portions of
> the patch that expose it to userspace?
>
> The rework to not use the VMA flag is pretty sizeable and is much more
> ugly IMO. I know that you are not wild about using bit 30 of 32 for
> this, but perhaps we can settle on not exporting it to userspace so we
> can reclaim it if we really need it in the future?
Yes, that would be definitely more acceptable for me. I do understand
that you are not wild about changing mremap behavior.
Anyway, I would really prefer if the vma flag was really used only at
few places - when we are clearing it along with VM_LOCKED (which could
be hidden in VM_LOCKED_CLEAR_MASK or something like that) and when we
decide whether the populate or not (this should be __mm_populate). But
maybe I am missing some call paths where gup is called unconditionally,
I haven't checked that.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2015-08-26 7:20 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-09 5:22 [PATCH v7 0/6] Allow user to request memory to be locked on page fault Eric B Munson
2015-08-09 5:22 ` [PATCH v7 2/6] mm: mlock: Add new mlock system call Eric B Munson
2015-08-12 9:45 ` Michal Hocko
2015-08-09 5:22 ` [PATCH v7 3/6] mm: Introduce VM_LOCKONFAULT Eric B Munson
2015-08-12 11:59 ` Michal Hocko
2015-08-19 21:33 ` Eric B Munson
[not found] ` <20150819213345.GB4536-JqFfY2XvxFXQT0dZR+AlfA@public.gmane.org>
2015-08-20 7:53 ` Vlastimil Babka
2015-08-20 7:56 ` Michal Hocko
2015-08-20 17:03 ` Eric B Munson
[not found] ` <20150820170309.GA11557-JqFfY2XvxFXQT0dZR+AlfA@public.gmane.org>
2015-08-21 7:25 ` Michal Hocko
[not found] ` <20150821072552.GF23723-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2015-08-21 18:31 ` Eric B Munson
[not found] ` <20150821183132.GA12835-JqFfY2XvxFXQT0dZR+AlfA@public.gmane.org>
2015-08-24 10:17 ` Konstantin Khlebnikov
2015-08-24 13:30 ` Vlastimil Babka
[not found] ` <55DB1C77.8070705-AlSwsSmVLrQ@public.gmane.org>
2015-08-24 13:50 ` Konstantin Khlebnikov
[not found] ` <CALYGNiNuZgQFzZ+_dQsPOvSJAX7QfZ38zbabn4wRc=oC5Lb9wA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-08-24 14:27 ` Vlastimil Babka
2015-08-24 15:09 ` Eric B Munson
2015-08-24 15:46 ` Konstantin Khlebnikov
2015-08-24 15:55 ` Eric B Munson
[not found] ` <20150824155503.GB17005-JqFfY2XvxFXQT0dZR+AlfA@public.gmane.org>
2015-08-24 16:22 ` Konstantin Khlebnikov
2015-08-24 17:00 ` Eric B Munson
[not found] ` <20150824170028.GC17005-JqFfY2XvxFXQT0dZR+AlfA@public.gmane.org>
2015-08-24 18:53 ` Konstantin Khlebnikov
[not found] ` <CALYGNiO3r9Yx7xeS-rZ_nVCR+BRP4d0-Fnd0omkBDdh1ftnExg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-08-24 20:26 ` Eric B Munson
2015-08-25 13:41 ` Michal Hocko
2015-08-25 13:55 ` Vlastimil Babka
2015-08-25 14:29 ` Michal Hocko
[not found] ` <20150825134154.GB6285-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2015-08-25 13:58 ` Konstantin Khlebnikov
2015-08-25 14:29 ` Eric B Munson
[not found] ` <20150825142902.GF17005-JqFfY2XvxFXQT0dZR+AlfA@public.gmane.org>
2015-08-25 18:58 ` Michal Hocko
2015-08-25 19:03 ` Eric B Munson
[not found] ` <20150825190300.GG17005-JqFfY2XvxFXQT0dZR+AlfA@public.gmane.org>
2015-08-26 7:20 ` Michal Hocko [this message]
2015-08-26 15:35 ` Vlastimil Babka
2015-08-09 5:22 ` [PATCH v7 4/6] mm: mlock: Add mlock flags to enable VM_LOCKONFAULT usage Eric B Munson
2015-08-09 5:22 ` [PATCH v7 5/6] selftests: vm: Add tests for lock on fault Eric B Munson
2015-08-09 5:22 ` [PATCH v7 6/6] mips: Add entry for new mlock2 syscall Eric B Munson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150826072016.GD25196@dhcp22.suse.cz \
--to=mhocko-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=corbet-T1hC0tSOHrs@public.gmane.org \
--cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=emunson-JqFfY2XvxFXQT0dZR+AlfA@public.gmane.org \
--cc=kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org \
--cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=vbabka-AlSwsSmVLrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).