From: Laurentiu Palcu <laurentiu.palcu@intel.com>
To: Andreas Dannenberg <dannenberg@ti.com>
Cc: Sebastian Reichel <sre@kernel.org>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Ramakrishna Pallala <ramakrishna.pallala@intel.com>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-api@vger.kernel.org
Subject: Re: [PATCH v6 08/14] power: bq24257: Use managed power supply register
Date: Fri, 25 Sep 2015 16:43:16 +0300 [thread overview]
Message-ID: <20150925134316.GE15509@lpalcu-desk> (raw)
In-Reply-To: <1443151618-29742-9-git-send-email-dannenberg@ti.com>
On Thu, Sep 24, 2015 at 10:26:52PM -0500, Andreas Dannenberg wrote:
[...]
> - bq->charger = power_supply_register(bq->dev, &bq24257_power_supply_desc,
> - &psy_cfg);
> + bq->charger = devm_power_supply_register(bq->dev,
> + &bq24257_power_supply_desc,
> + &psy_cfg);
> +
> if (IS_ERR(bq->charger))
> return PTR_ERR(bq->charger);
This is unrelated but, since we're here and if you ever send another
version for these patches, we could change these two lines (and the 'return
0' that follows) to just:
return PTR_ERR_OR_ZERO(bq->charger);
laurentiu
next prev parent reply other threads:[~2015-09-25 13:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-25 3:26 [PATCH v6 00/14] power: bq24257: Add support for bq24250/bq24251 Andreas Dannenberg
2015-09-25 3:26 ` [PATCH v6 02/14] power: bq24257: Remove IRQ config through stat-gpios Andreas Dannenberg
2015-09-25 3:26 ` [PATCH v6 03/14] power: bq24257: Streamline input current limit setup Andreas Dannenberg
[not found] ` <1443151618-29742-4-git-send-email-dannenberg-l0cyMroinI0@public.gmane.org>
2015-09-25 13:23 ` Laurentiu Palcu
2015-09-25 13:52 ` Andreas Dannenberg
2015-09-25 3:26 ` [PATCH v6 05/14] power: bq24257: Add bit definition for temp sense enable Andreas Dannenberg
2015-09-25 3:26 ` [PATCH v6 06/14] power: bq24257: Allow manual setting of input current limit Andreas Dannenberg
2015-09-25 3:26 ` [PATCH v6 07/14] power: bq24257: Add SW-based approach for Power Good determination Andreas Dannenberg
2015-09-25 3:26 ` [PATCH v6 08/14] power: bq24257: Use managed power supply register Andreas Dannenberg
2015-09-25 13:43 ` Laurentiu Palcu [this message]
[not found] ` <1443151618-29742-1-git-send-email-dannenberg-l0cyMroinI0@public.gmane.org>
2015-09-25 3:26 ` [PATCH v6 01/14] dt: power: bq24257-charger: Cover additional devices Andreas Dannenberg
2015-09-25 3:26 ` [PATCH v6 04/14] power: bq24257: Add basic support for bq24250/bq24251 Andreas Dannenberg
2015-09-25 3:26 ` [PATCH v6 09/14] power: bq24257: Add over voltage protection setting support Andreas Dannenberg
2015-09-25 3:26 ` [PATCH v6 10/14] power: bq24257: Add input DPM voltage threshold " Andreas Dannenberg
2015-09-25 3:26 ` [PATCH v6 11/14] power: bq24257: Allow input current limit sysfs access Andreas Dannenberg
2015-09-25 3:26 ` [PATCH v6 12/14] power: bq24257: Add various device-specific sysfs properties Andreas Dannenberg
2015-09-25 3:26 ` [PATCH v6 13/14] power: bq24257: Add platform data based initialization Andreas Dannenberg
2015-09-25 3:26 ` [PATCH v6 14/14] Documentation: power: bq24257: Document exported sysfs entries Andreas Dannenberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150925134316.GE15509@lpalcu-desk \
--to=laurentiu.palcu@intel.com \
--cc=dannenberg@ti.com \
--cc=dbaryshkov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=k.kozlowski@samsung.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=ramakrishna.pallala@intel.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).