From: Sebastian Reichel <sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Andreas Dannenberg <dannenberg-l0cyMroinI0@public.gmane.org>
Cc: Dmitry Eremin-Solenikov
<dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
Laurentiu Palcu
<laurentiu.palcu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Krzysztof Kozlowski
<k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
Ramakrishna Pallala
<ramakrishna.pallala-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v7 09/15] power: bq24257: Add SW-based approach for Power Good determination
Date: Sun, 27 Sep 2015 22:20:26 +0200 [thread overview]
Message-ID: <20150927202025.GA2051@earth> (raw)
In-Reply-To: <1443196460-26156-10-git-send-email-dannenberg-l0cyMroinI0@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 766 bytes --]
Hi,
On Fri, Sep 25, 2015 at 10:54:14AM -0500, Andreas Dannenberg wrote:
> @@ -651,15 +670,18 @@ static int bq24257_power_supply_init(struct bq24257_device *bq)
> return PTR_ERR_OR_ZERO(bq->charger);
> }
>
> -static int bq24257_pg_gpio_probe(struct bq24257_device *bq)
> +static void bq24257_pg_gpio_probe(struct bq24257_device *bq)
> {
> - bq->pg = devm_gpiod_get_index(bq->dev, BQ24257_PG_GPIO, 0, GPIOD_IN);
> + bq->pg = devm_gpiod_get_optional(bq->dev, BQ24257_PG_GPIO, GPIOD_IN);
> +
> if (IS_ERR(bq->pg)) {
> - dev_err(bq->dev, "could not probe PG pin\n");
> - return PTR_ERR(bq->pg);
> + dev_err(bq->dev, "error probing PG pin\n");
> + bq->pg = NULL;
> + return;
> }
You should handle -EPROBE_DEFER here.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-09-27 20:20 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-25 15:54 [PATCH v7 00/15] power: bq24257: Add support for bq24250/bq24251 Andreas Dannenberg
2015-09-25 15:54 ` [PATCH v7 06/15] power: bq24257: Add basic " Andreas Dannenberg
[not found] ` <1443196460-26156-7-git-send-email-dannenberg-l0cyMroinI0@public.gmane.org>
2015-09-28 13:14 ` Krzysztof Kozlowski
2015-09-28 13:38 ` Andreas Dannenberg
2015-09-25 15:54 ` [PATCH v7 07/15] power: bq24257: Add bit definition for temp sense enable Andreas Dannenberg
2015-09-25 15:54 ` [PATCH v7 15/15] Documentation: power: bq24257: Document exported sysfs entries Andreas Dannenberg
2015-09-28 12:14 ` [PATCH v7 00/15] power: bq24257: Add support for bq24250/bq24251 Krzysztof Kozlowski
[not found] ` <1443196460-26156-1-git-send-email-dannenberg-l0cyMroinI0@public.gmane.org>
2015-09-25 15:54 ` [PATCH v7 01/15] dt: power: bq24257-charger: Cover additional devices Andreas Dannenberg
[not found] ` <1443196460-26156-2-git-send-email-dannenberg-l0cyMroinI0@public.gmane.org>
2015-09-28 12:16 ` Krzysztof Kozlowski
2015-09-28 18:16 ` Sebastian Reichel
2015-09-25 15:54 ` [PATCH v7 02/15] power: bq24257: Remove IRQ config through stat-gpios Andreas Dannenberg
[not found] ` <1443196460-26156-3-git-send-email-dannenberg-l0cyMroinI0@public.gmane.org>
2015-09-28 16:38 ` Sebastian Reichel
2015-09-25 15:54 ` [PATCH v7 03/15] power: bq24257: Streamline input current limit setup Andreas Dannenberg
[not found] ` <1443196460-26156-4-git-send-email-dannenberg-l0cyMroinI0@public.gmane.org>
2015-09-28 16:53 ` Sebastian Reichel
2015-09-25 15:54 ` [PATCH v7 04/15] power: bq24257: Use managed power supply register Andreas Dannenberg
[not found] ` <1443196460-26156-5-git-send-email-dannenberg-l0cyMroinI0@public.gmane.org>
2015-09-28 13:10 ` Krzysztof Kozlowski
2015-09-28 17:22 ` Sebastian Reichel
2015-09-25 15:54 ` [PATCH v7 05/15] power: bq24257: Simplify bq24257_power_supply_init() Andreas Dannenberg
[not found] ` <1443196460-26156-6-git-send-email-dannenberg-l0cyMroinI0@public.gmane.org>
2015-09-28 13:10 ` Krzysztof Kozlowski
2015-09-25 15:54 ` [PATCH v7 08/15] power: bq24257: Allow manual setting of input current limit Andreas Dannenberg
2015-09-29 6:02 ` Krzysztof Kozlowski
2015-09-25 15:54 ` [PATCH v7 09/15] power: bq24257: Add SW-based approach for Power Good determination Andreas Dannenberg
[not found] ` <1443196460-26156-10-git-send-email-dannenberg-l0cyMroinI0@public.gmane.org>
2015-09-27 20:20 ` Sebastian Reichel [this message]
2015-09-28 12:04 ` Andreas Dannenberg
2015-09-28 15:49 ` Andreas Dannenberg
2015-09-28 16:02 ` Sebastian Reichel
2015-09-25 15:54 ` [PATCH v7 10/15] power: bq24257: Add over voltage protection setting support Andreas Dannenberg
2015-09-25 15:54 ` [PATCH v7 11/15] power: bq24257: Add input DPM voltage threshold " Andreas Dannenberg
2015-09-25 15:54 ` [PATCH v7 12/15] power: bq24257: Allow input current limit sysfs access Andreas Dannenberg
2015-09-25 15:54 ` [PATCH v7 13/15] power: bq24257: Add various device-specific sysfs properties Andreas Dannenberg
2015-09-25 15:54 ` [PATCH v7 14/15] power: bq24257: Add platform data based initialization Andreas Dannenberg
[not found] ` <1443196460-26156-15-git-send-email-dannenberg-l0cyMroinI0@public.gmane.org>
2015-09-28 17:58 ` Sebastian Reichel
2015-09-28 22:50 ` Andreas Dannenberg
2015-09-28 18:19 ` [PATCH v7 00/15] power: bq24257: Add support for bq24250/bq24251 Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150927202025.GA2051@earth \
--to=sre-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=dannenberg-l0cyMroinI0@public.gmane.org \
--cc=dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=laurentiu.palcu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ramakrishna.pallala-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).