From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH v5 7/9] vfs: Remove copy_file_range mountpoint checks Date: Wed, 14 Oct 2015 11:25:59 -0700 Message-ID: <20151014182559.GB31225@infradead.org> References: <1443634014-3026-1-git-send-email-Anna.Schumaker@Netapp.com> <1443634014-3026-8-git-send-email-Anna.Schumaker@Netapp.com> <20151011142347.GD31867@infradead.org> <561E93C3.2090507@Netapp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <561E93C3.2090507-ZwjVKphTwtPQT0dZR+AlfA@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Anna Schumaker Cc: Christoph Hellwig , linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-btrfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, zab-ugsP4Wv/S6ZeoWH0uzbU5w@public.gmane.org, viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org, clm-b10kYP2dOMg@public.gmane.org, darrick.wong-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org, mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, andros-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org List-Id: linux-api@vger.kernel.org On Wed, Oct 14, 2015 at 01:41:23PM -0400, Anna Schumaker wrote: > > NAK. I thing this is a bad idea in general and will only be convinced > > by a properly audited actual implementation. And even then with a flag > > where the file system specificly needs to opt into this behavior instead > > of getting it by default. > > > > So I should drop this patch even with the pagecache copy? Andy > Adamson will have to add it in later as part of his server-to-server patches. Yes. Let him do the proof it works alright then.