From: Andrew Morton <akpm@linux-foundation.org>
To: Jann Horn <jann@thejh.net>
Cc: Oleg Nesterov <oleg@redhat.com>, Ingo Molnar <mingo@redhat.com>,
James Morris <james.l.morris@oracle.com>,
"Serge E. Hallyn" <serge.hallyn@ubuntu.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Andy Lutomirski <luto@kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Joe Perches <joe@perches.com>,
Thomas Gleixner <tglx@linutronix.de>,
Michael Kerrisk <mtk.manpages@gmail.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-security-module@vger.kernel.org, linux-api@vger.kernel.org,
security@kernel.org, Willy Tarreau <w@1wt.eu>,
Kees Cook <keescook@google.com>
Subject: Re: [PATCH] ptrace: use fsuid, fsgid, effective creds for fs access checks
Date: Mon, 9 Nov 2015 13:19:02 -0800 [thread overview]
Message-ID: <20151109131902.db961a5fe7b7fcbeb14f72fc@linux-foundation.org> (raw)
In-Reply-To: <20151109211209.GA3236@pc.thejh.net>
On Mon, 9 Nov 2015 22:12:09 +0100 Jann Horn <jann@thejh.net> wrote:
>
> > Can we do
> >
> > #define PTRACE_foo (PTRACE_MODE_READ|PTRACE_MODE_FSCREDS)
> >
> > to avoid all that?
>
> Hm. All combinations of the PTRACE_MODE_*CREDS flags with
> PTRACE_MODE_{READ,ATTACH} plus optionally PTRACE_MODE_NOAUDIT
> make sense, I think. So your suggestion would be to create
> four new #defines
> PTRACE_MODE_{READ,ATTACH}_{FSCREDS,REALCREDS} and then let
> callers OR in the PTRACE_MODE_NOAUDIT flag if needed?
If these flag combinations have an identifiable concept behind them then
sure, it makes sense to capture that via a well-chosen identifier.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-11-09 21:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-08 12:08 [PATCH] ptrace: use fsuid, fsgid, effective creds for fs access checks Jann Horn
2015-11-09 20:55 ` Andrew Morton
2015-11-09 21:06 ` Willy Tarreau
[not found] ` <20151109125554.43e6a711e59d1b8bf99cdeb1-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2015-11-09 21:12 ` Jann Horn
2015-11-09 21:19 ` Andrew Morton [this message]
[not found] ` <20151109131902.db961a5fe7b7fcbeb14f72fc-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2015-12-06 2:04 ` Jann Horn
2015-12-07 20:32 ` Kees Cook
[not found] ` <CAGXu5jJKOnWWSuLO5zWZ9=7Nhv0hWvJ0wEVJ3n+URY7-q_BCJw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-12-07 20:38 ` Jann Horn
2015-12-07 21:25 ` Jann Horn
2015-12-07 21:25 ` [PATCH 1/2] security: let security modules use PTRACE_MODE_* with bitmasks Jann Horn
2015-12-07 21:30 ` Kees Cook
2015-12-07 21:51 ` Casey Schaufler
2015-12-07 21:25 ` [PATCH 2/2] ptrace: use fsuid, fsgid, effective creds for fs access checks Jann Horn
2015-12-07 21:27 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151109131902.db961a5fe7b7fcbeb14f72fc@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ebiederm@xmission.com \
--cc=james.l.morris@oracle.com \
--cc=jann@thejh.net \
--cc=joe@perches.com \
--cc=keescook@google.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-security-module@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=mtk.manpages@gmail.com \
--cc=oleg@redhat.com \
--cc=security@kernel.org \
--cc=serge.hallyn@ubuntu.com \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).