From: Eric Biggers <ebiggers3-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Anna Schumaker <Anna.Schumaker-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org>
Cc: linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-btrfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
zab-ugsP4Wv/S6ZeoWH0uzbU5w@public.gmane.org,
viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org,
clm-b10kYP2dOMg@public.gmane.org,
darrick.wong-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org,
mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
andros-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org,
hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org
Subject: Re: [PATCH v9 0/4] VFS: In-kernel copy system call
Date: Wed, 11 Nov 2015 08:53:37 -0600 [thread overview]
Message-ID: <20151111145337.GA2392@zzz> (raw)
In-Reply-To: <1447192413-15376-1-git-send-email-Anna.Schumaker-ZwjVKphTwtPQT0dZR+AlfA@public.gmane.org>
On Tue, Nov 10, 2015 at 04:53:30PM -0500, Anna Schumaker wrote:
> out:
> fdput(f_in);
> out1:
> fdput(f_out);
The fdput()s are in the wrong order. fdget(f_in) is first at the beginning, so
fdput(f_in) needs to be last at the end.
> /* this could be relaxed once a method supports cross-fs copies */
> if (inode_in->i_sb != inode_out->i_sb)
> return -EXDEV;
This allows the same superblock but different mounts --- is that intentional?
The commit message says otherwise: it says the vfs entry point requires the same
superblock and mount.
Was there a decision made on FMODE_PREAD and FMODE_PWRITE? To me it seems
logical that the if the user explicitly specifies an offset, then the
corresponding mode should be checked. That would check whether the file is
seekable or not, I believe. Note that e.g. sys_sendfile() does the same thing.
next prev parent reply other threads:[~2015-11-11 14:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-10 21:53 [PATCH v9 0/4] VFS: In-kernel copy system call Anna Schumaker
2015-11-10 21:53 ` [PATCH v9 1/4] vfs: add copy_file_range syscall and vfs helper Anna Schumaker
2015-11-10 21:53 ` [PATCH v9 3/4] btrfs: add .copy_file_range file operation Anna Schumaker
2015-11-10 21:53 ` [PATCH v9 4/4] vfs: Add vfs_copy_file_range() support for pagecache copies Anna Schumaker
2015-11-11 3:38 ` [PATCH v9 0/4] VFS: In-kernel copy system call Al Viro
[not found] ` <20151111033827.GJ22011-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org>
2015-11-11 14:00 ` Anna Schumaker
[not found] ` <1447192413-15376-1-git-send-email-Anna.Schumaker-ZwjVKphTwtPQT0dZR+AlfA@public.gmane.org>
2015-11-10 21:53 ` [PATCH v9 2/4] x86: add sys_copy_file_range to syscall tables Anna Schumaker
2015-11-11 14:53 ` Eric Biggers [this message]
2015-11-12 12:39 ` [PATCH v9 0/4] VFS: In-kernel copy system call Austin S Hemmelgarn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151111145337.GA2392@zzz \
--to=ebiggers3-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=Anna.Schumaker-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org \
--cc=andros-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org \
--cc=clm-b10kYP2dOMg@public.gmane.org \
--cc=darrick.wong-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-btrfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org \
--cc=zab-ugsP4Wv/S6ZeoWH0uzbU5w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).