From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: Punnaiah Choudary Kalluri <punnaiah.choudary.kalluri@xilinx.com>,
dwmw2@infradead.org, michals@xilinx.com,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-api@vger.kernel.org, kpc528@gmail.com,
kalluripunnaiahchoudary@gmail.com,
Punnaiah Choudary Kalluri <punnaia@xilinx.com>
Subject: Re: [PATCH] mtd: Expand the ecc placement locations to 1216
Date: Tue, 1 Dec 2015 12:15:12 +0100 [thread overview]
Message-ID: <20151201121512.40ce9cce@bbrezillon> (raw)
In-Reply-To: <20151120193342.GX64635@google.com>
Brian, Punnaiah,
On Fri, 20 Nov 2015 11:33:42 -0800
Brian Norris <computersforpeace@gmail.com> wrote:
> On Thu, Nov 05, 2015 at 10:28:55PM +0530, Punnaiah Choudary Kalluri wrote:
> > Device like MT29F32G08ABCDBJ4 have a writesize/oobsize of 16K/1216 Bytes.
> > So, increasing the maximum ecc placement locations to 1216
>
> I'd really prefer not increasing the size of the internal arrays any
> more. The structures should be rewritten to be dynamic.
I already started this migration (you can find the code here [1]). I
was planning to rework this series to make the eccpos definition mimic
what's done for oobfree (as suggested by Brian) before sending it, but
I'm not sure when I'll be able to do that, so if you really need that
quickly I suggest you submit those patches instead of reimplementing
it yourself.
Best Regards,
Boris
[1]https://github.com/bbrezillon/linux-sunxi/commits/nand/ecclayout
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-12-01 11:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-05 16:58 [PATCH] mtd: Expand the ecc placement locations to 1216 Punnaiah Choudary Kalluri
[not found] ` <1446742735-20824-1-git-send-email-punnaia-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
2015-11-20 19:33 ` Brian Norris
[not found] ` <20151120193342.GX64635-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2015-11-21 15:29 ` punnaiah choudary kalluri
[not found] ` <CAGnW=BZzoo1YFyAYx+oKkCPBOCTSz_KYY+t0=2wh4Fscx7e0eg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-11-30 21:11 ` Brian Norris
[not found] ` <20151130211105.GO64635-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2015-12-01 16:06 ` punnaiah choudary kalluri
2015-12-01 11:15 ` Boris Brezillon [this message]
2015-12-01 16:11 ` punnaiah choudary kalluri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151201121512.40ce9cce@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=kalluripunnaiahchoudary@gmail.com \
--cc=kpc528@gmail.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=michals@xilinx.com \
--cc=punnaia@xilinx.com \
--cc=punnaiah.choudary.kalluri@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).