From: Greg KH <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>
To: Vladimir Murzin <vladimir.murzin-5wv7dgnIgG8@public.gmane.org>
Cc: arnd-r2nGTMty4D4@public.gmane.org,
linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org,
daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org,
u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
jslaby-AlSwsSmVLrQ@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2 04/10] serial: mps2-uart: add MPS2 UART driver
Date: Mon, 8 Feb 2016 09:28:31 -0800 [thread overview]
Message-ID: <20160208172831.GB6715@kroah.com> (raw)
In-Reply-To: <56B8CDC5.5010504-5wv7dgnIgG8@public.gmane.org>
On Mon, Feb 08, 2016 at 05:17:57PM +0000, Vladimir Murzin wrote:
> On 08/02/16 16:52, Greg KH wrote:
> > On Mon, Feb 08, 2016 at 11:16:56AM +0000, Vladimir Murzin wrote:
> >> On 07/02/16 07:11, Greg KH wrote:
> >>>> +
> >>>> +#define SERIAL_NAME "ttyS"
> >>>
> >>> You can't be "ttyS", there's already a serial port named that, please
> >>> use a unique name and a new major/minor number (dynamic ideally).
> >>>
> >>
> >> Hi Greg,
> >>
> >> I did s/ttyMPS/ttyS per your request for v1 [1]. I'm fine to change it
> >> back if you prefer that, but I'd be glad to know what I've been missing?
> >>
> >> [1] https://lkml.org/lkml/2015/12/13/8
> >
> > Yeah, I was wrong, sorry about that, my fault.
> >
>
> I got -EDOUBT from my parser. What should I stick with "ttyS" or "ttyMPS"?
Please use ttyMPS.
> P.S.
> Any chance you could look at the rest of the patch?
It's long gone from my queue, sorry, you'll have to resend it.
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-02-08 17:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 11:39 [PATCH v2 00/10] Support for Cortex-M Prototyping System Vladimir Murzin
2016-02-02 11:39 ` [PATCH v2 01/10] dt-bindings: document the MPS2 timer bindings Vladimir Murzin
2016-02-02 11:39 ` [PATCH v2 02/10] clockevents/drivers: add MPS2 Timer driver Vladimir Murzin
[not found] ` <1454413199-26573-3-git-send-email-vladimir.murzin-5wv7dgnIgG8@public.gmane.org>
2016-02-02 13:04 ` Thomas Gleixner
2016-02-02 14:06 ` Vladimir Murzin
2016-02-02 11:39 ` [PATCH v2 03/10] dt-bindings: document the MPS2 UART bindings Vladimir Murzin
2016-02-02 11:39 ` [PATCH v2 04/10] serial: mps2-uart: add MPS2 UART driver Vladimir Murzin
[not found] ` <1454413199-26573-5-git-send-email-vladimir.murzin-5wv7dgnIgG8@public.gmane.org>
2016-02-07 7:11 ` Greg KH
[not found] ` <20160207071154.GA32017-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2016-02-08 11:16 ` Vladimir Murzin
[not found] ` <56B87928.7020803-5wv7dgnIgG8@public.gmane.org>
2016-02-08 16:52 ` Greg KH
2016-02-08 17:17 ` Vladimir Murzin
[not found] ` <56B8CDC5.5010504-5wv7dgnIgG8@public.gmane.org>
2016-02-08 17:28 ` Greg KH [this message]
2016-02-02 11:39 ` [PATCH v2 05/10] serial: mps2-uart: add support for early console Vladimir Murzin
2016-02-02 11:39 ` [PATCH v2 06/10] ARM: mps2: introduce MPS2 platform Vladimir Murzin
2016-02-02 11:39 ` [PATCH v2 07/10] ARM: mps2: add low-level debug support Vladimir Murzin
2016-02-02 11:39 ` [PATCH v2 08/10] ARM: configs: add MPS2 defconfig Vladimir Murzin
2016-02-02 11:39 ` [PATCH v2 09/10] ARM: dts: introduce MPS2 AN385/AN386 Vladimir Murzin
2016-02-02 11:39 ` [PATCH v2 10/10] ARM: dts: introduce MPS2 AN399/AN400 Vladimir Murzin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160208172831.GB6715@kroah.com \
--to=gregkh-hqyy1w1ycw8ekmwlsbkhg0b+6bgklq7r@public.gmane.org \
--cc=andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=jslaby-AlSwsSmVLrQ@public.gmane.org \
--cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
--cc=u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=vladimir.murzin-5wv7dgnIgG8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).