From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergey Senozhatsky Subject: Re: [PATCH 2/2] mm/page_ref: add tracepoint to track down page reference manipulation Date: Mon, 15 Feb 2016 14:28:55 +0900 Message-ID: <20160215052855.GA2010@swordfish> References: <1455505490-12376-1-git-send-email-iamjoonsoo.kim@lge.com> <1455505490-12376-2-git-send-email-iamjoonsoo.kim@lge.com> <20160215050858.GA556@swordfish> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20160215050858.GA556@swordfish> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sergey Senozhatsky Cc: js1304-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, Andrew Morton , Michal Nazarewicz , Minchan Kim , Mel Gorman , Vlastimil Babka , "Kirill A. Shutemov" , Steven Rostedt , linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Joonsoo Kim List-Id: linux-api@vger.kernel.org On (02/15/16 14:08), Sergey Senozhatsky wrote: > > will this compile with !CONFIG_TRACEPOINTS config? > uh.. sorry, was composed in email client. seems the correct way to do it is +#if defined CONFIG_DEBUG_PAGE_REF && defined CONFIG_TRACEPOINTS #include #define page_ref_tracepoint_active(t) static_key_false(&(t).key) extern struct tracepoint __tracepoint_page_ref_set; ... extern void __page_ref_set(struct page *page, int v); ... #else #define page_ref_tracepoint_active(t) false static inline void __page_ref_set(struct page *page, int v) { } ... #endif or add a dependency of PAGE_REF on CONFIG_TRACEPOINTS in Kconfig. -ss