* [PATCH] firmware: fw_cfg register offsets on supported architectures only
@ 2016-02-22 21:18 Gabriel Somlo
[not found] ` <20160222211818.GJ16357-h65ZQ0r4j6KKUezXOiBB2eW1CriLhL8O@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Gabriel Somlo @ 2016-02-22 21:18 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8,
mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg,
galak-sgV2jX0FEOL9JmXXK+q4OQ, arnd-r2nGTMty4D4,
lersek-H+wXaHxf7aLQT0dZR+AlfA, ralf-6z/3iImG2C8G8FEW9MqTrA,
rmk+kernel-lFZ/pmaqli7XmaaqVzeoHQ, eric-WhKQ6XTQaPysTnJN9+BGXg,
hanjun.guo-QSEj5FYQhm4dnm+yROfE0A, zajec5-Re5JQEeQqe8AvxtiuMwx3w,
sudeep.holla-5wv7dgnIgG8, agross-sgV2jX0FEOL9JmXXK+q4OQ,
linux-api-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA,
qemu-devel-qX2TKyscuCcdnm+yROfE0A,
imammedo-H+wXaHxf7aLQT0dZR+AlfA,
peter.maydell-QSEj5FYQhm4dnm+yROfE0A,
leif.lindholm-QSEj5FYQhm4dnm+yROfE0A,
ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A,
pbonzini-H+wXaHxf7aLQT0dZR+AlfA, kraxel-H+wXaHxf7aLQT0dZR+AlfA,
ehabkost-H+wXaHxf7aLQT0dZR+AlfA, luto-kltTT9wpgjJwATOyAt5JVQ,
stefanha-Re5JQEeQqe8AvxtiuMwx3w, revol-GANU6spQydw,
matt-mF/unelCI9GS6iBeEJttW/XRex20P6io, rth-hL46jP5Bxq7R7s880joybQ
Refrain from defining default fw_cfg register offsets on
unsupported architectures -- throw an error instead. If
QEMU were to add fw_cfg support on additional architectures,
we should add them to the FW_CFG_SYSFS depends statement in
drivers/firmware/Kconfig, and provide default values for
register offsets in drivers/firmware/qemu_fw_cfg.c at that
time.
Suggested-by: Michael S. Tsirkin <mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Signed-off-by: Gabriel Somlo <somlo-D+Gtc/HYRWM@public.gmane.org>
---
drivers/firmware/qemu_fw_cfg.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c
index fedbff5..79f6b7b 100644
--- a/drivers/firmware/qemu_fw_cfg.c
+++ b/drivers/firmware/qemu_fw_cfg.c
@@ -109,9 +109,7 @@ static void fw_cfg_io_cleanup(void)
# define FW_CFG_CTRL_OFF 0x00
# define FW_CFG_DATA_OFF 0x01
# else
-# warning "QEMU FW_CFG may not be available on this architecture!"
-# define FW_CFG_CTRL_OFF 0x00
-# define FW_CFG_DATA_OFF 0x01
+# error "QEMU FW_CFG not available on this architecture!"
# endif
#endif
--
2.4.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-23 5:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-22 21:18 [PATCH] firmware: fw_cfg register offsets on supported architectures only Gabriel Somlo
[not found] ` <20160222211818.GJ16357-h65ZQ0r4j6KKUezXOiBB2eW1CriLhL8O@public.gmane.org>
2016-02-23 5:08 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).