From mboxrd@z Thu Jan 1 00:00:00 1970 From: Petr Mladek Subject: Re: [PATCH v5 10/20] kthread: Better support freezable kthread workers Date: Fri, 26 Feb 2016 16:43:06 +0100 Message-ID: <20160226154305.GJ3305@pathway.suse.cz> References: <1456153030-12400-1-git-send-email-pmladek@suse.com> <1456153030-12400-11-git-send-email-pmladek@suse.com> <20160225130115.GJ6357@twins.programming.kicks-ass.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20160225130115.GJ6357-ndre7Fmf5hadTX5a5knrm8zTDFooKrT+cvkQGrU6aU0@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Peter Zijlstra Cc: Andrew Morton , Oleg Nesterov , Tejun Heo , Ingo Molnar , Steven Rostedt , "Paul E. McKenney" , Josh Triplett , Thomas Gleixner , Linus Torvalds , Jiri Kosina , Borislav Petkov , Michal Hocko , linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, Vlastimil Babka , linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-api@vger.kernel.org On Thu 2016-02-25 14:01:15, Peter Zijlstra wrote: > On Mon, Feb 22, 2016 at 03:57:00PM +0100, Petr Mladek wrote: > > +enum { > > + KTW_FREEZABLE = 1 << 2, /* freeze during suspend */ > > +}; > > Weird value; what was wrong with 1 << 0 ? Heh, the flag was inspired by WQ_FREEZABLE = 1 << 2, /* freeze during suspend */ from include/linux/workqueue.h. But it does not really matter. I could change it to 1 << 0 if it makes people less curious. Thanks a lot for review, Petr