From: Pavel Machek <pavel@ucw.cz>
To: "João Paulo Rechi Vita" <jprvita@gmail.com>
Cc: "Johannes Berg" <johannes@sipsolutions.net>,
"David S. Miller" <davem@davemloft.net>,
"Darren Hart" <dvhart@infradead.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
"Network Development" <netdev@vger.kernel.org>,
platform-driver-x86@vger.kernel.org, linux-api@vger.kernel.org,
linux-doc@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
linux@endlessm.com,
"João Paulo Rechi Vita" <jprvita@endlessm.com>
Subject: Re: [RESEND PATCH 1/3] rfkill: Create "rfkill-airplane-mode" LED trigger
Date: Mon, 13 Jun 2016 21:00:48 +0200 [thread overview]
Message-ID: <20160613190048.GA17101@amd> (raw)
In-Reply-To: <CA+A7VXXP3TYuk4Vvgc8YvxPFo06GG6WpyLJS+2vMLzr0iKQgsA@mail.gmail.com>
Hi!
> > João, that means you should send a patch to add the ::rfkill suffix.
> >
>
> IMO "airplane" (or maybe "airplane-mode") is a better suffix, as it
> reflects the label on the machine's chassis. I'll name it
> "asus-wireless::airplane" and send this through platform-drivers-x86,
> as this is now contained in the platform-drivers-x86 subsystem. Thanks
> Johannes for your patience and help designing and reviewing the rfkill
> changes, even if not all of them made it through in the end. And
> thanks everyone else involved for the feedback.
Actually, I'd do '::rfkill', for consistency with other places in
/sys.
/sys/devices/platform/thinkpad_acpi/rfkill/rfkill1/name
/sys/class/rfkill
/sys/module/rfkill
Thanks for patience,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2016-06-13 19:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-02 14:39 [RESEND PATCH 0/3] RFKill airplane-mode indicator João Paulo Rechi Vita
2016-05-02 14:39 ` [RESEND PATCH 1/3] rfkill: Create "rfkill-airplane-mode" LED trigger João Paulo Rechi Vita
2016-05-04 7:29 ` Pavel Machek
2016-05-12 9:32 ` Johannes Berg
2016-05-19 7:16 ` Pavel Machek
2016-06-09 12:43 ` Johannes Berg
2016-06-13 15:24 ` João Paulo Rechi Vita
2016-06-13 19:00 ` Pavel Machek [this message]
2016-06-13 19:59 ` João Paulo Rechi Vita
2016-06-13 21:01 ` Pavel Machek
2016-06-13 21:10 ` João Paulo Rechi Vita
2016-06-13 21:21 ` Pavel Machek
2016-06-21 9:35 ` Johannes Berg
2016-05-02 14:39 ` [RESEND PATCH 2/3] rfkill: Userspace control for airplane mode João Paulo Rechi Vita
2016-05-02 14:39 ` [RESEND PATCH 3/3] rfkill: Notify userspace of airplane-mode state changes João Paulo Rechi Vita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160613190048.GA17101@amd \
--to=pavel@ucw.cz \
--cc=davem@davemloft.net \
--cc=dvhart@infradead.org \
--cc=johannes@sipsolutions.net \
--cc=jprvita@endlessm.com \
--cc=jprvita@gmail.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@endlessm.com \
--cc=netdev@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).