Re: [PATCH 1/2] tracing/syscalls: allow multiple syscall numbers per syscall

Marcin Nowakowski
2016-08-31T07:00:01Z

On 31.08.2016 01:28, Steven Rostedt wrote:
> On Tue, 30 Aug 2016 16:09:04 -0700
> Andy Lutomirski <luto@amacapital.net> wrote:
>
>> But none of this should be a problem at all for MIPS, right? AFAICT
>> the only problem for MIPS is that there *is* a mapping from metadata
>> to nr. If that mapping got removed, MIPS should just work, right?
>
> Wait, where's the mapping of metadata to nr. I don't see that, nor do I
> see a need for that. The issue is that we have metadata that expresses
> how to record a syscall, and we map syscall nr to metadata, because
> when tracing is active, the only thing we have to find that metadata is
> the syscall nr.
>
> Now if a syscall nr has more than one way to record (a single nr for
> multiple syscalls), then we get into trouble. That's why we have
> trouble with compat syscalls. The same number maps to different
> syscalls, and we don't know how to differentiate that.

Generally it looks like the MIPS case is more simple than other arches -
as the syscall numbers for different ABIs are not overlapping, so when
trying to get syscall metadata the number is sufficient.
It's just a case that the current code doesn't handle correctly (and
just to makes things worse, while the compat syscalls are not supported
at the moment for any arch, because of how the syscalls are numbered,
tracing for native 64-bit code is currently broken).

But I agree with all the earlier comments that the current solution
isn't very nice - and even though my patch would solve the issue for
MIPS, all the existing issues would still remain elsewhere.

>>
>> For x86 compat, I think that adding arch should be sufficient.
>> Specifically, rather than having just one enter_syscall_files array,
>> have one per audit arch. Then call syscall_get_arch() as well as
>> syscall_get_nr() and use both to lookup the metadata. AFAIK this
>> should work on all architectures, although you might need some arch
>> helpers to enumerate all the arches and their respective syscall
>> tables (and max syscall nrs).
>
> OK, if the regs can get us to the arch, then this might work.
>
> That is, perhaps we can have multiple tables (not really sure how to
> make that happen in an arch agnostic way), and then have two functions:
>
> trace_get_syscall_nr(current, regs)
> trace_get_syscall_arch(current, regs)
>
> Although, that "arch" may be confusing.
>
> -- Steve
>