From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Rostedt Subject: Re: [PATCH 1/2] tracing/syscalls: allow multiple syscall numbers per syscall Date: Thu, 1 Sep 2016 11:24:28 -0400 Message-ID: <20160901112428.7c05dede@gandalf.local.home> References: <1472463007-6469-1-git-send-email-marcin.nowakowski@imgtec.com> <20160830152955.17633511@gandalf.local.home> <5227283.eAVLXfitJh@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5227283.eAVLXfitJh@wuerfel> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Arnd Bergmann Cc: Andy Lutomirski , Marcin Nowakowski , Linux API , Ingo Molnar , open list , Linux MIPS Mailing List List-Id: linux-api@vger.kernel.org On Wed, 31 Aug 2016 10:24:56 +0200 Arnd Bergmann wrote: > On Tuesday, August 30, 2016 12:53:53 PM CEST Andy Lutomirski wrote: > > Egads! OK, I see why this is a mess. > > > > I guess we should be creating the metadata from the syscall tables > > instead of from the syscall definitions, but I guess that's currently > > a nasty per-arch mess. > > > > I've been thinking for a while about how to improve the situation > around adding new syscalls, which currently involves adding a number > and an entry in a .S file on most architectures (some already have > their own method to simplify it, and others using a shared table > in asm-generic). > > I was thinking of extending the x86 way of doing this to all > architectures, and adding a way to have all future syscalls require > only one addition in a single file that gets included by the > architecture specific files for the existing syscalls. > > Assuming we do this, would that work for generating the metadata > from the same file like we do with > arch/x86/entry/syscalls/syscall{tbl,hdr}.sh ? I can't answer this because I'm not sure exactly how you would do this. Perhaps you could give it a try and code will be the answer to all my questions ;-) -- Steve