From: Greg KH <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>
To: Florian Weimer <fw-d32yF4oPJVt0XxTmqZlbVQ@public.gmane.org>
Cc: linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Christian Brauner
<christian.brauner-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
jslaby-IBi9RG/b67k@public.gmane.org
Subject: Re: Hard-coding PTY device node numbers in userspace
Date: Fri, 17 Feb 2017 10:15:38 -0800 [thread overview]
Message-ID: <20170217181538.GA9346@kroah.com> (raw)
In-Reply-To: <87bmu1jd0j.fsf-ZqZwdwZz9NfTBotR3TxKnbNAH6kLmebB@public.gmane.org>
On Fri, Feb 17, 2017 at 12:02:52PM +0100, Florian Weimer wrote:
> We want to reject PTY devices from other namespaces as valid input to
> the ttyname and ttyname_r functions, while still providing a hint to
> callers that the device is, in fact, a PTY. Christian Brauner wrote a
> glibc patch for this:
>
> <https://sourceware.org/ml/libc-alpha/2017-01/msg00531.html>
>
> It hard-codes the major PTY device number range. Is this feasible?
> Is it part of the stable userspace ABI for the TTY subsystem?
What major numbers are you using in the patch '2' and '3'? And yes,
major numbers are static and you should be fine to rely on them. But
can't you test that the device is a pty to verify it?
thanks,
greg k-h
next parent reply other threads:[~2017-02-17 18:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87bmu1jd0j.fsf@mid.deneb.enyo.de>
[not found] ` <87bmu1jd0j.fsf-ZqZwdwZz9NfTBotR3TxKnbNAH6kLmebB@public.gmane.org>
2017-02-17 18:15 ` Greg KH [this message]
[not found] ` <20170217181538.GA9346-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2017-02-19 15:35 ` Hard-coding PTY device node numbers in userspace Florian Weimer
[not found] ` <87d1eechxr.fsf-ZqZwdwZz9NfTBotR3TxKnbNAH6kLmebB@public.gmane.org>
2017-02-21 15:04 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170217181538.GA9346@kroah.com \
--to=gregkh-hqyy1w1ycw8ekmwlsbkhg0b+6bgklq7r@public.gmane.org \
--cc=christian.brauner-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org \
--cc=fw-d32yF4oPJVt0XxTmqZlbVQ@public.gmane.org \
--cc=jslaby-IBi9RG/b67k@public.gmane.org \
--cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).