From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next v3 03/13] sock: add MSG_ZEROCOPY Date: Thu, 22 Jun 2017 13:06:21 -0400 (EDT) Message-ID: <20170622.130621.2195651628293833337.davem@davemloft.net> References: <20170621211816.53837-1-willemdebruijn.kernel@gmail.com> <20170621211816.53837-4-willemdebruijn.kernel@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170621211816.53837-4-willemdebruijn.kernel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: willemdebruijn.kernel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, willemb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org List-Id: linux-api@vger.kernel.org From: Willem de Bruijn Date: Wed, 21 Jun 2017 17:18:06 -0400 > +struct ubuf_info *sock_zerocopy_alloc(struct sock *sk, size_t size) > +{ > + struct sk_buff *skb; > + struct ubuf_info *uarg; Reverse christmas tree. > +void sock_zerocopy_callback(struct ubuf_info *uarg, bool success) > +{ > + struct sock_exterr_skb *serr; > + struct sk_buff *skb = skb_from_uarg(uarg); > + struct sock *sk = skb->sk; > + u16 id = uarg->desc; Likewise.