From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Eric W. Biederman" Subject: [PATCH 6/8] signal/x86: Fix SIGSYS handling in copy_siginfo_to_user32 Date: Fri, 30 Jun 2017 07:39:04 -0500 Message-ID: <20170630123906.8865-6-ebiederm@xmission.com> References: <87efu22set.fsf@xmission.com> Return-path: In-Reply-To: <87efu22set.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: Andy Lutomirski , Linus Torvalds , Al Viro , Oleg Nesterov , Andrei Vagin , Thomas Gleixner , Greg KH , Andrey Vagin , Serge Hallyn , Pavel Emelyanov , Cyrill Gorcunov , Peter Zijlstra , Willy Tarreau , linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Linux Containers , Michael Kerrisk , "Eric W. Biederman" , Will Drewry , "H . Peter Anvin" , Eric Paris List-Id: linux-api@vger.kernel.org While examining the code I realized that we don't copy si_call_addr to 32bit callers. Fix it. It looks like no one has used this code path in the last 5 years. Cc: Will Drewry Cc: H. Peter Anvin Cc: Eric Paris Cc: Serge Hallyn Cc: James Morris Fixes: a0727e8ce513 ("signal, x86: add SIGSYS info and make it synchronous.") Signed-off-by: "Eric W. Biederman" --- arch/x86/kernel/signal_compat.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/kernel/signal_compat.c b/arch/x86/kernel/signal_compat.c index 71beb28600d4..59e1029bb3d0 100644 --- a/arch/x86/kernel/signal_compat.c +++ b/arch/x86/kernel/signal_compat.c @@ -161,6 +161,7 @@ int __copy_siginfo_to_user32(compat_siginfo_t __user *to, const siginfo_t *from, } break; case __SI_SYS >> 16: + put_user_ex(ptr_to_compat(from->si_call_addr), &to->si_call_addr); put_user_ex(from->si_syscall, &to->si_syscall); put_user_ex(from->si_arch, &to->si_arch); break; -- 2.10.1