From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Luis R. Rodriguez" Subject: Re: [RFC] vfs: skip extra attributes check on removal for symlinks Date: Wed, 9 May 2018 00:38:55 +0000 Message-ID: <20180509003855.GK27853@wotan.suse.de> References: <20180426234639.12480-1-mcgrof@kernel.org> <20180501172319.GK4127@magnolia> <20180501174512.GA27853@wotan.suse.de> <20180508003055.GC11261@magnolia> <20180509000327.GJ27853@wotan.suse.de> <20180509001741.GB11261@magnolia> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20180509001741.GB11261@magnolia> Sender: linux-kernel-owner@vger.kernel.org To: "Darrick J. Wong" Cc: "Luis R. Rodriguez" , viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, sandeen@sandeen.net, dhowells@redhat.com, tytso@mit.edu, fliu@suse.com, jack@suse.cz, jeffm@suse.com, nborisov@suse.com, jake.norris@suse.com, mtk.manpages@gmail.com, linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-api@vger.kernel.org On Tue, May 08, 2018 at 05:17:41PM -0700, Darrick J. Wong wrote: > On Wed, May 09, 2018 at 12:03:28AM +0000, Luis R. Rodriguez wrote: > > Groovy, thanks, let's not forget the xfs_repair respective fix :) let me know > > if you have any feedback on that. > > TBH I've lost any proposed xfs_repair patches to the mists of time > because some patch volcano keeps erupting on the lists. :P > > Uh... I think it's fine for xfs_{repair,scrub} to clear the immutable > and append flags on any special inodes it finds, particularly since > neither flag has any real meaning for block/char/fifo/socket/symlinks > anyway. Sure, my point during review of that series for xfs_repair in particular though was that for symlinks the justification is different (half of the commit log in this new patch), as such I'd prefer to deal with them in a separate follow up patch. Luis