From: Davidlohr Bueso <dave@stgolabs.net>
To: akpm@linux-foundation.org, torvalds@linux-foundation.org
Cc: tgraf@suug.ch, herbert@gondor.apana.org.au,
manfred@colorfullife.com, mhocko@kernel.org,
guillaume.knispel@supersonicimagine.com,
linux-api@vger.kernel.org, linux-kernel@vger.kernel.org,
Davidlohr Bueso <dave@stgolabs.net>
Subject: [PATCH -next v2 0/5] rhashtable: guarantee first allocation
Date: Fri, 1 Jun 2018 09:01:20 -0700 [thread overview]
Message-ID: <20180601160125.30031-1-dave@stgolabs.net> (raw)
Changes from v1
lkml.kernel.org/r/20180524211135.27760-1-dave@stgolabs.net
- patch 2 is reworked a bit based on the commments from Herbert Xu.
o upon failure, retry immediately with GFP_NOFAIL (simpler)
o the caller now passes the needed semantics, not bucket_table_alloc().
o we consider min_size when resizing, not just HASH_MIN_SIZE.
- removed patch 3; not need after Michal's patch.
Hi,
This series is the result of the discussion with Linus around ipc
subsystem initialization and how it behaves with error return when
calling rhashtable_init()[1]. Instead of caring about the error
or calling the infamous BUG_ON, Linus suggested we guarantee the
rhashtable allocation.
First two patches modify rhashtable_init() to just return 0, future
patches will update more callers, particularly those that use BUG_ON.
patch 3+4 remove some ipc hacks we no longer need.
patch 5 updates the rhashtable test module. Trivial.
Please consider for v4.18.
Thanks!
[0] https://lkml.org/lkml/2018/5/23/758
Davidlohr Bueso (5):
lib/rhashtable: convert param sanitations to WARN_ON
lib/rhashtable: guarantee initial hashtable allocation
ipc: get rid of ids->tables_initialized hack
ipc: simplify ipc initialization
lib/test_rhashtable: rhashtable_init() can no longer fail
include/linux/ipc_namespace.h | 1 -
ipc/msg.c | 9 ++++-----
ipc/namespace.c | 20 ++++----------------
ipc/sem.c | 10 ++++------
ipc/shm.c | 9 ++++-----
ipc/util.c | 41 +++++++++++++----------------------------
ipc/util.h | 18 +++++++++---------
lib/rhashtable.c | 22 ++++++++++++++--------
lib/test_rhashtable.c | 6 +-----
9 files changed, 53 insertions(+), 83 deletions(-)
--
2.16.3
next reply other threads:[~2018-06-01 16:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-01 16:01 Davidlohr Bueso [this message]
2018-06-01 16:01 ` [PATCH 1/5] lib/rhashtable: convert param sanitations to WARN_ON Davidlohr Bueso
2018-06-01 16:09 ` Herbert Xu
2018-06-01 16:53 ` Davidlohr Bueso
2018-06-01 16:59 ` Herbert Xu
2018-06-01 17:10 ` Davidlohr Bueso
2018-06-01 16:01 ` [PATCH 2/5] lib/rhashtable: guarantee initial hashtable allocation Davidlohr Bueso
2018-06-02 4:41 ` Herbert Xu
2018-06-02 5:41 ` Davidlohr Bueso
2018-06-02 15:53 ` Herbert Xu
2018-06-04 11:46 ` Michal Hocko
2018-06-01 16:01 ` [PATCH 3/5] ipc: get rid of ids->tables_initialized hack Davidlohr Bueso
2018-06-01 16:01 ` [PATCH 4/5] ipc: simplify ipc initialization Davidlohr Bueso
2018-06-01 16:01 ` [PATCH 5/5] lib/test_rhashtable: rhashtable_init() can no longer fail Davidlohr Bueso
2018-06-02 4:42 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180601160125.30031-1-dave@stgolabs.net \
--to=dave@stgolabs.net \
--cc=akpm@linux-foundation.org \
--cc=guillaume.knispel@supersonicimagine.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
--cc=mhocko@kernel.org \
--cc=tgraf@suug.ch \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).