From: Davidlohr Bueso <dave@stgolabs.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: akpm@linux-foundation.org, torvalds@linux-foundation.org,
tgraf@suug.ch, manfred@colorfullife.com, mhocko@kernel.org,
guillaume.knispel@supersonicimagine.com,
linux-api@vger.kernel.org, linux-kernel@vger.kernel.org,
Davidlohr Bueso <dbueso@suse.de>
Subject: Re: [PATCH 1/5] lib/rhashtable: convert param sanitations to WARN_ON
Date: Fri, 1 Jun 2018 10:10:28 -0700 [thread overview]
Message-ID: <20180601171028.3rjlozqmuoofa3iy@linux-r8p5> (raw)
In-Reply-To: <20180601165903.bd3jonbv2jrfcevi@gondor.apana.org.au>
On Sat, 02 Jun 2018, Herbert Xu wrote:
>On Fri, Jun 01, 2018 at 09:53:47AM -0700, Davidlohr Bueso wrote:
>>
>> Curious, are these users setting up the param structure dynamically
>> or something that they can pass along bogus values?
>>
>> If that's the case then yes, I definitely agree.
>
>It's just a quality of implementation issue. This is a generic API.
>Sure for early-boot users like yours it makes sense to just WARN_ON
>rather than deal with the messy hash table allocation failure.
>
>But for a driver author writing some kernel module it isn't nice
>to WARN_ON and then crash on a NULL-pointer dereference when we
>can cleanly fail the table init.
Fine, at least patch 2 applies without this one. So Andrew, if you
consider taking this series please drop patch 1 and 5 (which no
longer makes sense as rhashtable_init() won't be returning void
in the future).
If you want me to resend (assuming other issues are not pointed out),
I can do but I wanted to avoid spamming more the necessary.
Thanks,
Davidlohr
next prev parent reply other threads:[~2018-06-01 17:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-01 16:01 [PATCH -next v2 0/5] rhashtable: guarantee first allocation Davidlohr Bueso
2018-06-01 16:01 ` [PATCH 1/5] lib/rhashtable: convert param sanitations to WARN_ON Davidlohr Bueso
2018-06-01 16:09 ` Herbert Xu
2018-06-01 16:53 ` Davidlohr Bueso
2018-06-01 16:59 ` Herbert Xu
2018-06-01 17:10 ` Davidlohr Bueso [this message]
2018-06-01 16:01 ` [PATCH 2/5] lib/rhashtable: guarantee initial hashtable allocation Davidlohr Bueso
2018-06-02 4:41 ` Herbert Xu
2018-06-02 5:41 ` Davidlohr Bueso
2018-06-02 15:53 ` Herbert Xu
2018-06-04 11:46 ` Michal Hocko
2018-06-01 16:01 ` [PATCH 3/5] ipc: get rid of ids->tables_initialized hack Davidlohr Bueso
2018-06-01 16:01 ` [PATCH 4/5] ipc: simplify ipc initialization Davidlohr Bueso
2018-06-01 16:01 ` [PATCH 5/5] lib/test_rhashtable: rhashtable_init() can no longer fail Davidlohr Bueso
2018-06-02 4:42 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180601171028.3rjlozqmuoofa3iy@linux-r8p5 \
--to=dave@stgolabs.net \
--cc=akpm@linux-foundation.org \
--cc=dbueso@suse.de \
--cc=guillaume.knispel@supersonicimagine.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
--cc=mhocko@kernel.org \
--cc=tgraf@suug.ch \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox