From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keith Busch Subject: Re: [PATCHv6 07/10] acpi/hmat: Register processor domain to its memory Date: Fri, 22 Feb 2019 11:48:31 -0700 Message-ID: <20190222184831.GF10237@localhost.localdomain> References: <20190214171017.9362-1-keith.busch@intel.com> <20190214171017.9362-8-keith.busch@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: "Rafael J. Wysocki" Cc: Linux Kernel Mailing List , ACPI Devel Maling List , Linux Memory Management List , Linux API , Greg Kroah-Hartman , Dave Hansen , Dan Williams List-Id: linux-api@vger.kernel.org On Wed, Feb 20, 2019 at 11:02:01PM +0100, Rafael J. Wysocki wrote: > On Thu, Feb 14, 2019 at 6:10 PM Keith Busch wrote: > > config ACPI_HMAT > > bool "ACPI Heterogeneous Memory Attribute Table Support" > > depends on ACPI_NUMA > > + select HMEM_REPORTING > > If you want to do this here, I'm not sure that defining HMEM_REPORTING > as a user-selectable option is a good idea. In particular, I don't > really think that setting ACPI_HMAT without it makes a lot of sense. > Apart from this, the patch looks reasonable to me. I'm trying to implement based on the feedback, but I'm a little confused. As I have it at the moment, HMEM_REPORTING is not user-prompted, so another option needs to turn it on. I have ACPI_HMAT do that here. So when you say it's a bad idea to make HMEM_REPORTING user selectable, isn't it already not user selectable? If I do it the other way around, that's going to make HMEM_REPORTING complicated if a non-ACPI implementation wants to report HMEM properties.