From: Cyril Hrubis <chrubis@suse.cz>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Oscar Salvador <osalvador@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-api@vger.kernel.org, hughd@google.com,
kirill@shutemov.name, joel@joelfernandes.org, jglisse@redhat.com,
yang.shi@linux.alibaba.com, mgorman@techsingularity.net
Subject: Re: [PATCH] mm,mremap: Bail out earlier in mremap_to under map pressure
Date: Fri, 1 Mar 2019 16:25:48 +0100 [thread overview]
Message-ID: <20190301152547.GA25732@rei> (raw)
In-Reply-To: <5edcfeb8-4f53-0fe6-1e5b-c1e485f91d0d@suse.cz>
Hi!
> Hopefully the only program that would start failing would be a LTP test
> testing the current behavior near the limit (if such test exists). And
> that can be adjusted.
There does not seem to be a mremap() test that would do such a thing, so
we should be safe :-).
BTW there was a similar fix for mmap() with MAP_FIXED that caused a LTP
test to fail and was fixed in:
commit e8420a8ece80b3fe810415ecf061d54ca7fab266
Author: Cyril Hrubis <chrubis@suse.cz>
Date: Mon Apr 29 15:08:33 2013 -0700
mm/mmap: check for RLIMIT_AS before unmapping
And I haven't heard of any breakages so far so I guess that this very
similar situation and that the possibility of breaking real world
applications here is really low.
--
Cyril Hrubis
chrubis@suse.cz
prev parent reply other threads:[~2019-03-01 15:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 9:13 [PATCH] mm,mremap: Bail out earlier in mremap_to under map pressure Oscar Salvador
2019-02-26 22:04 ` Andrew Morton
2019-02-27 21:32 ` Oscar Salvador
2019-02-28 8:06 ` Vlastimil Babka
2019-02-28 20:44 ` Joel Fernandes
2019-03-01 15:25 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190301152547.GA25732@rei \
--to=chrubis@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=jglisse@redhat.com \
--cc=joel@joelfernandes.org \
--cc=kirill@shutemov.name \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=osalvador@suse.de \
--cc=vbabka@suse.cz \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).