From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick Bellasi Subject: Re: [PATCH v7 01/15] sched/core: uclamp: Add CPU's clamp buckets refcounting Date: Thu, 14 Mar 2019 14:54:56 +0000 Message-ID: <20190314145456.5qpxchfltfauqaem@e110439-lin> References: <20190208100554.32196-1-patrick.bellasi@arm.com> <20190208100554.32196-2-patrick.bellasi@arm.com> <21171fa0-7fd5-ebbf-dd48-d6668ed563af@arm.com> <20190313151535.q5ivsuywvwkewrk5@e110439-lin> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Suren Baghdasaryan Cc: Dietmar Eggemann , LKML , linux-pm@vger.kernel.org, linux-api@vger.kernel.org, Ingo Molnar , Peter Zijlstra , Tejun Heo , "Rafael J . Wysocki" , Vincent Guittot , Viresh Kumar , Paul Turner , Quentin Perret , Morten Rasmussen , Juri Lelli , Todd Kjos , Joel Fernandes , Steve Muckle List-Id: linux-api@vger.kernel.org On 13-Mar 14:01, Suren Baghdasaryan wrote: > On Wed, Mar 13, 2019 at 8:15 AM Patrick Bellasi wrote: > > > > On 12-Mar 13:52, Dietmar Eggemann wrote: > > > On 2/8/19 11:05 AM, Patrick Bellasi wrote: [...] > > > > +static inline unsigned int uclamp_bucket_value(unsigned int clamp_value) > > > > +{ > > > > + return UCLAMP_BUCKET_DELTA * uclamp_bucket_id(clamp_value); > > > > +} > > > > > > Soemthing like uclamp_bucket_nominal_value() should be clearer. > > > > Maybe... can update it in v8 > > > > uclamp_bucket_base_value is a little shorter, just to consider :) Right, I also like it better ;) -- #include Patrick Bellasi