From: David Miller <davem@davemloft.net>
To: arnd@arndb.de
Cc: linux-api@vger.kernel.org, linux-arch@vger.kernel.org,
netdev@vger.kernel.org, labbott@redhat.com, fw@deneb.enyo.de,
pburton@wavecomp.com, deepa.kernel@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] uapi: avoid namespace conflict in linux/posix_types.h
Date: Tue, 19 Mar 2019 14:46:48 -0700 (PDT) [thread overview]
Message-ID: <20190319.144648.2244362851338248970.davem@davemloft.net> (raw)
In-Reply-To: <20190319165123.3967889-1-arnd@arndb.de>
From: Arnd Bergmann <arnd@arndb.de>
Date: Tue, 19 Mar 2019 17:51:09 +0100
> Florian Weimer points out an issue with including linux/posix_types.h
> from arbitrary other headers: if an application has defined a macro
> named 'fds_bits', it may stop compiling after a change in the kernel
> headers. Since fds_bits is a non-reserved identifier in C, that is
> considered a bug in the kernel headers.
>
> The structure definition does not really seem to be helpful here,
> as the kernel no longer provides macros to manipulate it.
...
> Fixes: a623a7a1a567 ("y2038: fix socket.h header inclusion")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: David S. Miller <davem@davemloft.net>
next prev parent reply other threads:[~2019-03-19 21:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 16:51 [PATCH] uapi: avoid namespace conflict in linux/posix_types.h Arnd Bergmann
2019-03-19 21:46 ` David Miller [this message]
2019-03-19 21:55 ` Florian Weimer
2019-05-07 22:50 ` Joseph Myers
2019-06-07 4:28 ` Florian Weimer
2019-06-07 18:27 ` Linus Torvalds
2019-06-07 18:43 ` Florian Weimer
2019-06-07 18:56 ` Linus Torvalds
2019-06-17 11:45 ` Florian Weimer
2019-06-17 17:49 ` Linus Torvalds
2019-06-17 18:02 ` Florian Weimer
2019-06-17 18:13 ` Linus Torvalds
2019-06-17 18:16 ` Linus Torvalds
2019-06-17 18:19 ` Florian Weimer
2019-06-17 18:48 ` Linus Torvalds
2019-06-18 7:44 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190319.144648.2244362851338248970.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arnd@arndb.de \
--cc=deepa.kernel@gmail.com \
--cc=fw@deneb.enyo.de \
--cc=labbott@redhat.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pburton@wavecomp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).