From: Eric Biggers <ebiggers@kernel.org>
To: linux-fscrypt@vger.kernel.org
Cc: Satya Tangirala <satyat@google.com>,
linux-api@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, keyrings@vger.kernel.org,
linux-mtd@lists.infradead.org, linux-crypto@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
Paul Crowley <paulcrowley@google.com>
Subject: [PATCH v4 16/17] ubifs: wire up new fscrypt ioctls
Date: Tue, 2 Apr 2019 08:45:59 -0700 [thread overview]
Message-ID: <20190402154600.32432-17-ebiggers@kernel.org> (raw)
In-Reply-To: <20190402154600.32432-1-ebiggers@kernel.org>
From: Eric Biggers <ebiggers@google.com>
Wire up the new ioctls for adding and removing fscrypt keys to/from the
filesystem, and the new ioctl for retrieving v2 encryption policies.
FS_IOC_REMOVE_ENCRYPTION_KEY also required making UBIFS use
fscrypt_drop_inode().
For more details see Documentation/filesystems/fscrypt.rst, as well as
the fscrypt patches that added the implementation of these ioctls.
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
fs/ubifs/ioctl.c | 23 +++++++++++++++++------
fs/ubifs/super.c | 11 +++++++++++
2 files changed, 28 insertions(+), 6 deletions(-)
diff --git a/fs/ubifs/ioctl.c b/fs/ubifs/ioctl.c
index 82e4e6a30b044..3c640a7e937f4 100644
--- a/fs/ubifs/ioctl.c
+++ b/fs/ubifs/ioctl.c
@@ -205,13 +205,20 @@ long ubifs_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
return -EOPNOTSUPP;
#endif
}
- case FS_IOC_GET_ENCRYPTION_POLICY: {
-#ifdef CONFIG_FS_ENCRYPTION
+ case FS_IOC_GET_ENCRYPTION_POLICY:
return fscrypt_ioctl_get_policy(file, (void __user *)arg);
-#else
- return -EOPNOTSUPP;
-#endif
- }
+
+ case FS_IOC_GET_ENCRYPTION_POLICY_EX:
+ return fscrypt_ioctl_get_policy_ex(file, (void __user *)arg);
+
+ case FS_IOC_ADD_ENCRYPTION_KEY:
+ return fscrypt_ioctl_add_key(file, (void __user *)arg);
+
+ case FS_IOC_REMOVE_ENCRYPTION_KEY:
+ return fscrypt_ioctl_remove_key(file, (const void __user *)arg);
+
+ case FS_IOC_GET_ENCRYPTION_KEY_STATUS:
+ return fscrypt_ioctl_get_key_status(file, (void __user *)arg);
default:
return -ENOTTY;
@@ -230,6 +237,10 @@ long ubifs_compat_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
break;
case FS_IOC_SET_ENCRYPTION_POLICY:
case FS_IOC_GET_ENCRYPTION_POLICY:
+ case FS_IOC_GET_ENCRYPTION_POLICY_EX:
+ case FS_IOC_ADD_ENCRYPTION_KEY:
+ case FS_IOC_REMOVE_ENCRYPTION_KEY:
+ case FS_IOC_GET_ENCRYPTION_KEY_STATUS:
break;
default:
return -ENOIOCTLCMD;
diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
index 8dc2818fdd849..cd4a3e2be2043 100644
--- a/fs/ubifs/super.c
+++ b/fs/ubifs/super.c
@@ -334,6 +334,16 @@ static int ubifs_write_inode(struct inode *inode, struct writeback_control *wbc)
return err;
}
+static int ubifs_drop_inode(struct inode *inode)
+{
+ int drop = generic_drop_inode(inode);
+
+ if (!drop)
+ drop = fscrypt_drop_inode(inode);
+
+ return drop;
+}
+
static void ubifs_evict_inode(struct inode *inode)
{
int err;
@@ -1982,6 +1992,7 @@ const struct super_operations ubifs_super_operations = {
.destroy_inode = ubifs_destroy_inode,
.put_super = ubifs_put_super,
.write_inode = ubifs_write_inode,
+ .drop_inode = ubifs_drop_inode,
.evict_inode = ubifs_evict_inode,
.statfs = ubifs_statfs,
.dirty_inode = ubifs_dirty_inode,
--
2.21.0
next prev parent reply other threads:[~2019-04-02 15:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-02 15:45 [PATCH v4 00/17] fscrypt: key management improvements Eric Biggers
2019-04-02 15:45 ` [PATCH v4 01/17] fs, fscrypt: move uapi definitions to new header <linux/fscrypt.h> Eric Biggers
2019-04-02 15:45 ` [PATCH v4 02/17] fscrypt: use FSCRYPT_ prefix for uapi constants Eric Biggers
2019-04-02 15:45 ` [PATCH v4 03/17] fscrypt: use FSCRYPT_* definitions, not FS_* Eric Biggers
2019-04-02 15:45 ` [PATCH v4 04/17] fscrypt: add ->ci_inode to fscrypt_info Eric Biggers
2019-04-02 15:45 ` [PATCH v4 05/17] fscrypt: refactor v1 policy key setup into keysetup_legacy.c Eric Biggers
2019-04-02 15:45 ` [PATCH v4 06/17] fscrypt: add FS_IOC_ADD_ENCRYPTION_KEY ioctl Eric Biggers
2019-04-02 15:45 ` [PATCH v4 07/17] fs/dcache.c: add shrink_dcache_inode() Eric Biggers
2019-04-03 18:34 ` Al Viro
2019-04-03 20:36 ` Eric Biggers
2019-04-02 15:45 ` [PATCH v4 08/17] fscrypt: add FS_IOC_REMOVE_ENCRYPTION_KEY ioctl Eric Biggers
2019-04-02 15:45 ` [PATCH v4 09/17] fscrypt: add FS_IOC_GET_ENCRYPTION_KEY_STATUS ioctl Eric Biggers
2019-04-02 15:45 ` [PATCH v4 10/17] fscrypt: add an HKDF-SHA512 implementation Eric Biggers
2019-04-02 15:45 ` [PATCH v4 11/17] fscrypt: v2 encryption policy support Eric Biggers
2019-04-02 15:45 ` [PATCH v4 12/17] fscrypt: allow unprivileged users to add/remove keys for v2 policies Eric Biggers
2019-04-02 15:45 ` [PATCH v4 13/17] fscrypt: require that key be added when setting a v2 encryption policy Eric Biggers
2019-04-02 15:45 ` [PATCH v4 14/17] ext4: wire up new fscrypt ioctls Eric Biggers
2019-04-02 15:45 ` [PATCH v4 15/17] f2fs: " Eric Biggers
2019-04-02 15:45 ` Eric Biggers [this message]
2019-04-02 15:46 ` [PATCH v4 17/17] fscrypt: document the new ioctls and policy version Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190402154600.32432-17-ebiggers@kernel.org \
--to=ebiggers@kernel.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=paulcrowley@google.com \
--cc=satyat@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).