From: Andrew Murray <andrew.murray@arm.com>
To: Dave Martin <Dave.Martin@arm.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
libc-alpha@sourceware.org, Szabolcs Nagy <Szabolcs.Nagy@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>, Phil Blundell <pb@pbcl.net>,
linux-api@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 6/7] arm64: Advertise ARM64_HAS_DCPODP cpu feature
Date: Wed, 3 Apr 2019 10:23:42 +0100 [thread overview]
Message-ID: <20190403092342.GI53702@e119886-lin.cambridge.arm.com> (raw)
In-Reply-To: <20190402145958.GJ3567@e103592.cambridge.arm.com>
On Tue, Apr 02, 2019 at 03:59:58PM +0100, Dave Martin wrote:
> On Mon, Apr 01, 2019 at 11:45:14AM +0100, Andrew Murray wrote:
> > Advertise ARM64_HAS_DCPOP when both DC CVAP and DC CVADP are supported.
>
> Do you mean ARM64_HAS_DCPODP?
Yes I did - good catch.
>
> And do we need this? This capability flag doesn't currently appear to
> be used for anything (which makes me wonder whether it _should_ be wired
> up to something in the kernel).
>
> Do we expect the kernel to do something special with this in the future?
>
> OTOH, we get a nice printk when the feature is detected, and the code
> size cost is insignificant. So, if there's a reasonable expectation that
> we will use it someday, I don't see a big problem with having it.
Yes it's not currently used, so I'm happy to drop this patch if people prefer
that - however it does complement the existing DCPOP cap which is present.
Thanks,
Andrew Murray
>
> Cheers
> ---Dave
>
> >
> > Signed-off-by: Andrew Murray <andrew.murray@arm.com>
> > ---
> > arch/arm64/include/asm/cpucaps.h | 3 ++-
> > arch/arm64/kernel/cpufeature.c | 9 +++++++++
> > 2 files changed, 11 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/include/asm/cpucaps.h b/arch/arm64/include/asm/cpucaps.h
> > index f6a76e43f39e..defdc67d9ab4 100644
> > --- a/arch/arm64/include/asm/cpucaps.h
> > +++ b/arch/arm64/include/asm/cpucaps.h
> > @@ -61,7 +61,8 @@
> > #define ARM64_HAS_GENERIC_AUTH_ARCH 40
> > #define ARM64_HAS_GENERIC_AUTH_IMP_DEF 41
> > #define ARM64_HAS_IRQ_PRIO_MASKING 42
> > +#define ARM64_HAS_DCPODP 43
> >
> > -#define ARM64_NCAPS 43
> > +#define ARM64_NCAPS 44
> >
> > #endif /* __ASM_CPUCAPS_H */
> > diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c
> > index 5e27d2dbe45e..c74b25895c43 100644
> > --- a/arch/arm64/kernel/cpufeature.c
> > +++ b/arch/arm64/kernel/cpufeature.c
> > @@ -1339,6 +1339,15 @@ static const struct arm64_cpu_capabilities arm64_features[] = {
> > .field_pos = ID_AA64ISAR1_DPB_SHIFT,
> > .min_field_value = 1,
> > },
> > + {
> > + .desc = "Data cache clean to Point of Deep Persistence",
> > + .capability = ARM64_HAS_DCPODP,
> > + .type = ARM64_CPUCAP_SYSTEM_FEATURE,
> > + .matches = has_cpuid_feature,
> > + .sys_reg = SYS_ID_AA64ISAR1_EL1,
> > + .field_pos = ID_AA64ISAR1_DPB_SHIFT,
> > + .min_field_value = 2,
> > + },
> > #endif
> > #ifdef CONFIG_ARM64_SVE
> > {
> > --
> > 2.21.0
> >
next prev parent reply other threads:[~2019-04-03 9:23 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-01 10:45 [PATCH v3 0/7] arm64: Initial support for CVADP Andrew Murray
2019-04-01 10:45 ` [PATCH v3 1/7] arm64: Handle trapped DC CVADP Andrew Murray
2019-04-01 10:45 ` [PATCH v3 2/7] arm64: HWCAP: add support for AT_HWCAP2 Andrew Murray
2019-04-02 14:58 ` Dave Martin
2019-04-03 8:32 ` Andrew Murray
2019-04-03 9:11 ` Dave Martin
2019-04-03 9:29 ` Andrew Murray
2019-04-03 9:35 ` Dave Martin
2019-04-01 10:45 ` [PATCH v3 3/7] arm64: HWCAP: encapsulate elf_hwcap Andrew Murray
2019-04-02 14:58 ` Dave Martin
2019-04-02 15:06 ` Andrew Murray
2019-04-02 15:32 ` Suzuki K Poulose
2019-04-02 15:55 ` Dave Martin
2019-04-03 8:53 ` Andrew Murray
2019-04-03 9:13 ` Dave Martin
2019-04-01 10:45 ` [PATCH v3 4/7] arm64: Expose DC CVADP to userspace Andrew Murray
2019-04-01 10:45 ` [PATCH v3 5/7] arm64: add CVADP support to the cache maintenance helper Andrew Murray
2019-04-01 10:45 ` [PATCH v3 6/7] arm64: Advertise ARM64_HAS_DCPODP cpu feature Andrew Murray
2019-04-02 14:59 ` Dave Martin
2019-04-03 9:23 ` Andrew Murray [this message]
2019-04-03 9:32 ` Dave Martin
2019-04-03 9:57 ` Andrew Murray
2019-04-01 10:45 ` [PATCH v3 7/7] arm64: docs: document AT_HWCAP2 and unused AT_HWCAP bits Andrew Murray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190403092342.GI53702@e119886-lin.cambridge.arm.com \
--to=andrew.murray@arm.com \
--cc=Dave.Martin@arm.com \
--cc=Szabolcs.Nagy@arm.com \
--cc=catalin.marinas@arm.com \
--cc=libc-alpha@sourceware.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=pb@pbcl.net \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).