From: Alexey Dobriyan <adobriyan@gmail.com>
To: "Li, Aubrey" <aubrey.li@linux.intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
mingo@redhat.com, Peter Zijlstra <peterz@infradead.org>,
"H. Peter Anvin" <hpa@zytor.com>,
ak@linux.intel.com, tim.c.chen@linux.intel.com,
dave.hansen@intel.com, arjan@linux.intel.com,
aubrey.li@intel.com, LKML <linux-kernel@vger.kernel.org>,
Linux API <linux-api@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v13 1/3] /proc/pid/status: Add support for architecture specific output
Date: Sun, 7 Apr 2019 18:46:22 +0300 [thread overview]
Message-ID: <20190407154622.GA16004@avx2> (raw)
In-Reply-To: <7cd8fa2d-301a-5c96-ce3d-3dc373a5d8f5@linux.intel.com>
On Sun, Apr 07, 2019 at 09:02:38PM +0800, Li, Aubrey wrote:
> On 2019/4/7 5:41, Alexey Dobriyan wrote:
> > On Fri, Apr 05, 2019 at 09:32:35PM +0200, Thomas Gleixner wrote:
> >>> +/* Add support for architecture specific output in /proc/pid/status */
> >>> +extern void arch_proc_pid_status(struct seq_file *m, struct task_struct *task);
> > ^^^^^^
> >
> > Unnecessary extern.
> >
> The linkage is default extern, but with this functions and variables
> can be treated the same way.
>
> Is it mandatory not to use it explicitly? ./script/checkpatch.pl did
> not report this.
"extern" is only necessary for variables. For prototypes, it is more typing
and more characters on the screen.
checkpatch.pl doesn't report it because opening floodgates is not the plan.
Yours,
Extern Police.
next prev parent reply other threads:[~2019-04-07 15:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190224044400.34975-1-aubrey.li@linux.intel.com>
2019-04-05 19:32 ` [PATCH v13 1/3] /proc/pid/status: Add support for architecture specific output Thomas Gleixner
2019-04-06 21:41 ` Alexey Dobriyan
2019-04-07 13:02 ` Li, Aubrey
2019-04-07 15:46 ` Alexey Dobriyan [this message]
2019-04-08 0:45 ` Li, Aubrey
2019-04-07 17:34 ` Andy Lutomirski
2019-04-08 0:38 ` Li, Aubrey
2019-04-08 1:52 ` Andy Lutomirski
2019-04-08 2:33 ` Li, Aubrey
[not found] ` <20190224044400.34975-2-aubrey.li@linux.intel.com>
2019-04-05 20:27 ` [PATCH v13 2/3] x86,/proc/pid/status: Add AVX-512 usage elapsed time Jann Horn
2019-04-06 15:41 ` Li, Aubrey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190407154622.GA16004@avx2 \
--to=adobriyan@gmail.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=arjan@linux.intel.com \
--cc=aubrey.li@intel.com \
--cc=aubrey.li@linux.intel.com \
--cc=dave.hansen@intel.com \
--cc=hpa@zytor.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).