From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oleg Nesterov Subject: Re: [PATCH v1 3/4] signal: support CLONE_PIDFD with pidfd_send_signal Date: Wed, 17 Apr 2019 16:01:06 +0200 Message-ID: <20190417140106.GG32622@redhat.com> References: <20190416170233.10208-1-christian@brauner.io> <20190416170233.10208-4-christian@brauner.io> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190416170233.10208-4-christian@brauner.io> Sender: linux-kernel-owner@vger.kernel.org To: Christian Brauner Cc: torvalds@linux-foundation.org, viro@zeniv.linux.org.uk, jannh@google.com, dhowells@redhat.com, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, serge@hallyn.com, luto@kernel.org, arnd@arndb.de, ebiederm@xmission.com, keescook@chromium.org, tglx@linutronix.de, mtk.manpages@gmail.com, akpm@linux-foundation.org, cyphar@cyphar.com, joel@joelfernandes.org, dancol@google.com List-Id: linux-api@vger.kernel.org On 04/16, Christian Brauner wrote: > > @@ -3581,12 +3588,12 @@ SYSCALL_DEFINE4(pidfd_send_signal, int, pidfd, int, sig, > if (flags) > return -EINVAL; > > - f = fdget_raw(pidfd); > + f = fdget(pidfd); could you explain this change? I am just curious, I don't understand why should we disallow O_PATH and how this connects to this patch. Oleg.