From: Oleg Nesterov <oleg@redhat.com>
To: Christian Brauner <christian@brauner.io>
Cc: torvalds@linux-foundation.org, viro@zeniv.linux.org.uk,
jannh@google.com, dhowells@redhat.com, linux-api@vger.kernel.org,
linux-kernel@vger.kernel.org, serge@hallyn.com, luto@kernel.org,
arnd@arndb.de, ebiederm@xmission.com, keescook@chromium.org,
tglx@linutronix.de, mtk.manpages@gmail.com,
akpm@linux-foundation.org, cyphar@cyphar.com,
joel@joelfernandes.org, dancol@google.com,
Jann Horn <jann@thejh.net>
Subject: Re: [PATCH v3 4/4] samples: show race-free pidfd metadata access
Date: Fri, 19 Apr 2019 17:30:48 +0200 [thread overview]
Message-ID: <20190419153047.GA12228@redhat.com> (raw)
In-Reply-To: <20190419120904.27502-5-christian@brauner.io>
On 04/19, Christian Brauner wrote:
>
> +int main(int argc, char *argv[])
> +{
> + int ret = EXIT_FAILURE;
> + char buf[4096] = { 0 };
> + pid_t pid;
> + int pidfd, procfd, statusfd;
I think you need to initialize pidfd = 0 in this version ;) Otherwise,
Reviewed-by: Oleg Nesterov <oleg@redhat.com>
next prev parent reply other threads:[~2019-04-19 15:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-19 12:09 [PATCH v3 0/4] clone: add CLONE_PIDFD Christian Brauner
2019-04-19 12:09 ` [PATCH v3 1/4] Make anon_inodes unconditional Christian Brauner
2019-04-23 7:13 ` Enrico Weigelt, metux IT consult
2019-04-19 12:09 ` [PATCH v3 2/4] clone: add CLONE_PIDFD Christian Brauner
2019-04-19 12:09 ` [PATCH v3 3/4] signal: support CLONE_PIDFD with pidfd_send_signal Christian Brauner
2019-04-19 12:09 ` [PATCH v3 4/4] samples: show race-free pidfd metadata access Christian Brauner
2019-04-19 15:30 ` Oleg Nesterov [this message]
2019-04-19 16:38 ` Christian Brauner
2019-04-19 20:05 ` [PATCH v3 0/4] clone: add CLONE_PIDFD Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190419153047.GA12228@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=christian@brauner.io \
--cc=cyphar@cyphar.com \
--cc=dancol@google.com \
--cc=dhowells@redhat.com \
--cc=ebiederm@xmission.com \
--cc=jann@thejh.net \
--cc=jannh@google.com \
--cc=joel@joelfernandes.org \
--cc=keescook@chromium.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=serge@hallyn.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).