From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey Gladkov Subject: Re: [PATCH v3] moduleparam: Save information about built-in modules in separate file Date: Mon, 29 Apr 2019 17:35:55 +0200 Message-ID: <20190429153555.GX9023@dhcp129-178.brq.redhat.com> References: <20190429090854.GU9023@dhcp129-178.brq.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Masahiro Yamada Cc: Linux Kernel Mailing List , Linux Kbuild mailing list , linux-api@vger.kernel.org, linux-modules@vger.kernel.org, "Kirill A . Shutemov" , Gleb Fotengauer-Malinovskiy , "Dmitry V. Levin" , Michal Marek , Dmitry Torokhov , Rusty Russell , Jessica Yu , Lucas De Marchi List-Id: linux-api@vger.kernel.org On Tue, Apr 30, 2019 at 12:08:44AM +0900, Masahiro Yamada wrote: > > modules.builtin > > +modules.builtin.modinfo > > > > # > > # Top-level generic files > > > Let me repeat the same comments as in v2 > (https://patchwork.kernel.org/patch/10888207/#22595563) > as you ignored them. I miss it. Sorry about that. > > diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh > > index c8cf45362bd6..41ef7cb043c1 100755 > > --- a/scripts/link-vmlinux.sh > > +++ b/scripts/link-vmlinux.sh > > @@ -226,6 +226,10 @@ modpost_link vmlinux.o > > # modpost vmlinux.o to check for section mismatches > > ${MAKE} -f "${srctree}/scripts/Makefile.modpost" vmlinux.o > > > > +info MODINFO modules.builtin.modinfo > > +"${OBJCOPY}" -j .modinfo -O binary vmlinux.o modules.builtin.modinfo > > +chmod 444 modules.builtin.modinfo > > > Why is this 'chmod 444' necessary? I just wanted to show that this file will never change. I will remove this line. -- Rgrds, legion