From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Theodore Ts'o" Subject: Re: [PATCH v4 04/16] fs: uapi: define verity bit for FS_IOC_GETFLAGS Date: Sat, 15 Jun 2019 08:40:48 -0400 Message-ID: <20190615124048.GE6142@mit.edu> References: <20190606155205.2872-1-ebiggers@kernel.org> <20190606155205.2872-5-ebiggers@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20190606155205.2872-5-ebiggers@kernel.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net To: Eric Biggers Cc: "Darrick J . Wong" , linux-api@vger.kernel.org, Dave Chinner , linux-f2fs-devel@lists.sourceforge.net, linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org, Jaegeuk Kim , linux-integrity@vger.kernel.org, linux-ext4@vger.kernel.org, Linus Torvalds , Christoph Hellwig , Victor Hsieh List-Id: linux-api@vger.kernel.org On Thu, Jun 06, 2019 at 08:51:53AM -0700, Eric Biggers wrote: > From: Eric Biggers > > Add FS_VERITY_FL to the flags for FS_IOC_GETFLAGS, so that applications > can easily determine whether a file is a verity file at the same time as > they're checking other file flags. This flag will be gettable only; > FS_IOC_SETFLAGS won't allow setting it, since an ioctl must be used > instead to provide more parameters. > > This flag matches the on-disk bit that was already allocated for ext4. > > Signed-off-by: Eric Biggers Looks good; you can add: Reviewed-off-by: Theodore Ts'o - Ted