From mboxrd@z Thu Jan 1 00:00:00 1970 From: Minchan Kim Subject: Re: [PATCH v3 1/5] mm: introduce MADV_COLD Date: Fri, 28 Jun 2019 08:56:18 +0900 Message-ID: <20190627235618.GC33052@google.com> References: <20190627115405.255259-1-minchan@kernel.org> <20190627115405.255259-2-minchan@kernel.org> <343599f9-3d99-b74f-1732-368e584fa5ef@intel.com> <20190627140203.GB5303@dhcp22.suse.cz> <20190627145302.GC5303@dhcp22.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190627145302.GC5303@dhcp22.suse.cz> Sender: linux-kernel-owner@vger.kernel.org To: Michal Hocko Cc: Dave Hansen , Andrew Morton , linux-mm , LKML , linux-api@vger.kernel.org, Johannes Weiner , Tim Murray , Joel Fernandes , Suren Baghdasaryan , Daniel Colascione , Shakeel Butt , Sonny Rao , oleksandr@redhat.com, hdanton@sina.com, lizeb@google.com, "Kirill A . Shutemov" List-Id: linux-api@vger.kernel.org On Thu, Jun 27, 2019 at 04:53:02PM +0200, Michal Hocko wrote: > On Thu 27-06-19 07:36:50, Dave Hansen wrote: > [...] > > For MADV_COLD, if we defined it like this, I think we could use it for > > both purposes (demotion and LRU movement): > > > > Pages in the specified regions will be treated as less-recently- > > accessed compared to pages in the system with similar access > > frequencies. In contrast to MADV_DONTNEED, the contents of the > > you meant s@MADV_DONTNEED@MADV_FREE@ I suppose Right, MADV_FREE is more proper because it's aging related. > > > region are preserved. > > > > It would be nice not to talk about reclaim at all since we're not > > promising reclaim per se. Your suggestion doesn't expose any implementation detail and could meet your needs later. I'm okay. I will change it if others are not against of it. Thanks, Dave.