From: Dave Young <dyoung@redhat.com>
To: Matthew Garrett <matthewgarrett@google.com>
Cc: jmorris@namei.org, linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
Josh Boyer <jwboyer@redhat.com>,
David Howells <dhowells@redhat.com>,
Matthew Garrett <mjg59@google.com>,
Borislav Petkov <bp@alien8.de>, Kees Cook <keescook@chromium.org>,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH V35 15/29] acpi: Ignore acpi_rsdp kernel param when the kernel has been locked down
Date: Tue, 16 Jul 2019 10:59:23 +0800 [thread overview]
Message-ID: <20190716025923.GA5793@dhcp-128-65.nay.redhat.com> (raw)
In-Reply-To: <20190715195946.223443-16-matthewgarrett@google.com>
Hi,
On 07/15/19 at 12:59pm, Matthew Garrett wrote:
> From: Josh Boyer <jwboyer@redhat.com>
>
> This option allows userspace to pass the RSDP address to the kernel, which
> makes it possible for a user to modify the workings of hardware . Reject
> the option when the kernel is locked down.
>
> Signed-off-by: Josh Boyer <jwboyer@redhat.com>
> Signed-off-by: David Howells <dhowells@redhat.com>
> Signed-off-by: Matthew Garrett <mjg59@google.com>
> Reviewed-by: Kees Cook <keescook@chromium.org>
> cc: Dave Young <dyoung@redhat.com>
> cc: linux-acpi@vger.kernel.org
> ---
> drivers/acpi/osl.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
> index 9c0edf2fc0dd..06e7cffc4386 100644
> --- a/drivers/acpi/osl.c
> +++ b/drivers/acpi/osl.c
> @@ -26,6 +26,7 @@
> #include <linux/list.h>
> #include <linux/jiffies.h>
> #include <linux/semaphore.h>
> +#include <linux/security.h>
>
> #include <asm/io.h>
> #include <linux/uaccess.h>
> @@ -180,7 +181,7 @@ acpi_physical_address __init acpi_os_get_root_pointer(void)
> acpi_physical_address pa;
>
> #ifdef CONFIG_KEXEC
> - if (acpi_rsdp)
> + if (acpi_rsdp && !security_locked_down(LOCKDOWN_ACPI_TABLES))
> return acpi_rsdp;
I'm very sorry I noticed this late, but have to say this will not work for
X86 with latest kernel code.
acpi_physical_address __init acpi_os_get_root_pointer(void)
{
acpi_physical_address pa;
#ifdef CONFIG_KEXEC
if (acpi_rsdp)
return acpi_rsdp;
#endif
pa = acpi_arch_get_root_pointer();
if (pa)
return pa;
[snip]
In above code, the later acpi_arch_get_root_pointer still get acpi_rsdp
from cmdline param if provided.
You can check the arch/x86/boot/compressed/acpi.c, and
arch/x86/kernel/acpi/boot.c
In X86 early code, cmdline provided acpi_rsdp pointer will be saved in boot_params.acpi_rsdp_addr;
and the used in x86_default_get_root_pointer
> #endif
> pa = acpi_arch_get_root_pointer();
> --
> 2.22.0.510.g264f2c817a-goog
>
Thanks
Dave
next prev parent reply other threads:[~2019-07-16 2:59 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 19:59 [PATCH V35 00/29] Kernel lockdown functionality Matthew Garrett
2019-07-15 19:59 ` [PATCH V35 01/29] security: Support early LSMs Matthew Garrett
2019-07-15 19:59 ` [PATCH V35 02/29] security: Add a "locked down" LSM hook Matthew Garrett
2019-07-15 19:59 ` [PATCH V35 03/29] security: Add a static lockdown policy LSM Matthew Garrett
2019-07-15 19:59 ` [PATCH V35 04/29] Enforce module signatures if the kernel is locked down Matthew Garrett
2019-07-15 19:59 ` [PATCH V35 05/29] Restrict /dev/{mem,kmem,port} when " Matthew Garrett
[not found] ` <20190715195946.223443-1-matthewgarrett-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2019-07-15 19:59 ` [PATCH V35 06/29] kexec_load: Disable at runtime if " Matthew Garrett
2019-07-15 19:59 ` [PATCH V35 07/29] Copy secure_boot flag in boot params across kexec reboot Matthew Garrett
2019-07-15 19:59 ` [PATCH V35 09/29] kexec_file: Restrict at runtime if the kernel is locked down Matthew Garrett
2019-07-15 19:59 ` [PATCH V35 08/29] kexec_file: split KEXEC_VERIFY_SIG into KEXEC_SIG and KEXEC_SIG_FORCE Matthew Garrett
2019-07-15 19:59 ` [PATCH V35 10/29] hibernate: Disable when the kernel is locked down Matthew Garrett
2019-07-15 19:59 ` [PATCH V35 11/29] PCI: Lock down BAR access " Matthew Garrett
2019-07-15 19:59 ` [PATCH V35 12/29] x86: Lock down IO port " Matthew Garrett
2019-07-15 19:59 ` [PATCH V35 13/29] x86/msr: Restrict MSR " Matthew Garrett
2019-07-15 19:59 ` [PATCH V35 14/29] ACPI: Limit access to custom_method " Matthew Garrett
2019-07-15 19:59 ` [PATCH V35 15/29] acpi: Ignore acpi_rsdp kernel param when the kernel has been " Matthew Garrett
2019-07-16 2:59 ` Dave Young [this message]
2019-07-16 20:34 ` Matthew Garrett
2019-07-15 19:59 ` [PATCH V35 16/29] acpi: Disable ACPI table override if the kernel is " Matthew Garrett
2019-07-15 19:59 ` [PATCH V35 17/29] Prohibit PCMCIA CIS storage when " Matthew Garrett
2019-07-15 19:59 ` [PATCH V35 18/29] Lock down TIOCSSERIAL Matthew Garrett
2019-07-15 19:59 ` [PATCH V35 19/29] Lock down module params that specify hardware parameters (eg. ioport) Matthew Garrett
2019-07-15 23:26 ` James Morris
2019-07-15 19:59 ` [PATCH V35 20/29] x86/mmiotrace: Lock down the testmmiotrace module Matthew Garrett
2019-07-15 19:59 ` [PATCH V35 21/29] Lock down /proc/kcore Matthew Garrett
2019-07-15 19:59 ` [PATCH V35 22/29] Lock down tracing and perf kprobes when in confidentiality mode Matthew Garrett
2019-07-15 19:59 ` [PATCH V35 23/29] bpf: Restrict bpf when kernel lockdown is " Matthew Garrett
2019-07-15 22:54 ` Daniel Borkmann
2019-07-16 20:32 ` Matthew Garrett
2019-07-15 19:59 ` [PATCH V35 24/29] Lock down perf when " Matthew Garrett
2019-07-15 19:59 ` [PATCH V35 25/29] kexec: Allow kexec_file() with appropriate IMA policy when locked down Matthew Garrett
2019-07-15 19:59 ` [PATCH V35 26/29] debugfs: Restrict debugfs when the kernel is " Matthew Garrett
2019-07-15 23:17 ` James Morris
2019-07-15 19:59 ` [PATCH V35 27/29] tracefs: Restrict tracefs " Matthew Garrett
2019-07-16 23:14 ` Steven Rostedt
2019-07-16 23:22 ` Matthew Garrett
2019-07-15 19:59 ` [PATCH V35 28/29] efi: Restrict efivar_ssdt_load " Matthew Garrett
2019-07-15 19:59 ` [PATCH V35 29/29] lockdown: Print current->comm in restriction messages Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190716025923.GA5793@dhcp-128-65.nay.redhat.com \
--to=dyoung@redhat.com \
--cc=bp@alien8.de \
--cc=dhowells@redhat.com \
--cc=jmorris@namei.org \
--cc=jwboyer@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=matthewgarrett@google.com \
--cc=mjg59@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).