From: Al Viro <viro@zeniv.linux.org.uk>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Christian Brauner <christian@brauner.io>,
Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
David Howells <dhowells@redhat.com>,
Miklos Szeredi <miklos@szeredi.hu>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Linux API <linux-api@vger.kernel.org>
Subject: Re: Regression in 5.3 for some FS_USERNS_MOUNT (aka user-namespace-mountable) filesystems
Date: Sat, 27 Jul 2019 03:28:26 +0100 [thread overview]
Message-ID: <20190727022826.GO1131@ZenIV.linux.org.uk> (raw)
In-Reply-To: <878sskqp7p.fsf@xmission.com>
On Fri, Jul 26, 2019 at 07:46:18PM -0500, Eric W. Biederman wrote:
> If someone had bothered to actually look at how I was proposing to clean
> things up before the new mount api we would already have that. Sigh.
>
> You should be able to get away with something like this which moves the
> checks earlier and makes things clearer. My old patch against the pre
> new mount api code.
Check your instances of ->permission(); AFAICS in all cases it's (in
current terms)
return ns_capable(fc->user_ns, CAP_SYS_ADMIN) ? 0 : -EPERM;
In principle I like killing FS_USERNS_MOUNT flag, but when a method
is always either NULL or exact same function...
next prev parent reply other threads:[~2019-07-27 2:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-26 11:59 Regression in 5.3 for some FS_USERNS_MOUNT (aka user-namespace-mountable) filesystems Christian Brauner
2019-07-26 22:47 ` Linus Torvalds
2019-07-26 23:22 ` Al Viro
2019-07-27 0:46 ` Eric W. Biederman
2019-07-27 2:28 ` Al Viro [this message]
2019-07-27 11:20 ` Eric W. Biederman
2019-07-27 12:37 ` Al Viro
2019-07-27 13:17 ` Al Viro
2019-07-27 2:23 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190727022826.GO1131@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=christian@brauner.io \
--cc=dhowells@redhat.com \
--cc=ebiederm@xmission.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).