From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrei Vagin Subject: Re: [PATCHv5 06/37] alarmtimer: Provide get_timespec() callback Date: Wed, 7 Aug 2019 23:18:19 -0700 Message-ID: <20190808061819.GA20004@gmail.com> References: <20190729215758.28405-1-dima@arista.com> <20190729215758.28405-7-dima@arista.com> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Thomas Gleixner Cc: Dmitry Safonov , linux-kernel@vger.kernel.org, Dmitry Safonov <0x7f454c46@gmail.com>, Adrian Reber , Andrei Vagin , Andy Lutomirski , Arnd Bergmann , Christian Brauner , Cyrill Gorcunov , "Eric W. Biederman" , "H. Peter Anvin" , Ingo Molnar , Jann Horn , Jeff Dike , Oleg Nesterov , Pavel Emelyanov , Shuah Khan , Vincenzo Frascino , containers@lists.linux-foundation.org, criu@openvz.org, linux-api@vger.kernel.org, x86@kernel.org List-Id: linux-api@vger.kernel.org On Wed, Aug 07, 2019 at 08:04:10AM +0200, Thomas Gleixner wrote: > On Mon, 29 Jul 2019, Dmitry Safonov wrote: > > /** > > @@ -869,8 +871,10 @@ static int __init alarmtimer_init(void) > > /* Initialize alarm bases */ > > alarm_bases[ALARM_REALTIME].base_clockid = CLOCK_REALTIME; > > alarm_bases[ALARM_REALTIME].get_ktime = &ktime_get_real; > > + alarm_bases[ALARM_REALTIME].get_timespec = posix_get_timespec, > > That's just wrong: > > > /* > > * Get monotonic time for posix timers > > */ > > -static int posix_get_timespec(clockid_t which_clock, struct timespec64 *tp) > > +int posix_get_timespec(clockid_t which_clock, struct timespec64 *tp) > > { > > ktime_get_ts64(tp); > > return 0; > > Using a proper function name would have avoided this. You are right. Will fix. Thanks! >