From: Kees Cook <keescook@chromium.org>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Florian Weimer <fw@deneb.enyo.de>,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
linux-api@vger.kernel.org, Jann Horn <jannh@google.com>,
Arnd Bergmann <arnd@arndb.de>, Helge Deller <deller@gmx.de>
Subject: Re: [REPOST][RFC][PATCH] sysctl: Remove the sysctl system call
Date: Thu, 3 Oct 2019 14:05:24 -0700 [thread overview]
Message-ID: <201910031404.C30A0F16@keescook> (raw)
In-Reply-To: <87tv8pftjj.fsf_-_@x220.int.ebiederm.org>
On Thu, Oct 03, 2019 at 03:44:32PM -0500, Eric W. Biederman wrote:
>
> This system call has been deprecated almost since it was introduced, and none
> of the common distributions enable it. The only indication that I can find that
> anyone might care is that a few of the defconfigs in the kernel enable it. However
> that is a small fractions of the defconfigs so I suspect it just a lack of care
> rather than a reflection of software using the the sysctl system call.
>
> As there appear to be no users of the sysctl system call, remove the
> code so that the proc filesystem can be simplified.
nitpick: line lengths near 80 characters
> Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
But, yes, I would love to see this gone. :)
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
next prev parent reply other threads:[~2019-10-03 21:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <8736gcjosv.fsf@x220.int.ebiederm.org>
2019-10-01 18:46 ` [RFC][PATCH] sysctl: Remove the sysctl system call Kees Cook
2019-10-01 22:53 ` Eric W. Biederman
2019-10-02 0:40 ` Jann Horn
2019-10-02 7:31 ` Arnd Bergmann
2019-10-02 14:41 ` Eric W. Biederman
2019-10-02 14:49 ` Eric W. Biederman
2019-10-02 18:52 ` Helge Deller
2019-10-03 6:56 ` Florian Weimer
[not found] ` <87tv8pftjj.fsf_-_@x220.int.ebiederm.org>
2019-10-03 21:05 ` Kees Cook [this message]
2019-10-08 10:30 ` [REPOST][RFC][PATCH] " Michael Kerrisk (man-pages)
2019-10-03 21:08 ` [RFC][PATCH] " Christian Brauner
2019-10-04 7:31 ` vger mail woes? (was: Re: [RFC][PATCH] sysctl: Remove the sysctl system call) Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201910031404.C30A0F16@keescook \
--to=keescook@chromium.org \
--cc=arnd@arndb.de \
--cc=deller@gmx.de \
--cc=ebiederm@xmission.com \
--cc=fw@deneb.enyo.de \
--cc=jannh@google.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).