From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oleg Nesterov Subject: Re: [PATCH v3 1/2] clone3: add CLONE_CLEAR_SIGHAND Date: Mon, 21 Oct 2019 16:46:33 +0200 Message-ID: <20191021144633.GA2720@redhat.com> References: <20191014104538.3096-1-christian.brauner@ubuntu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20191014104538.3096-1-christian.brauner@ubuntu.com> Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org To: Christian Brauner Cc: linux-kernel@vger.kernel.org, Florian Weimer , Arnd Bergmann , libc-alpha@sourceware.org, David Howells , Jann Horn , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Shuah Khan , Andrew Morton , Michal Hocko , Elena Reshetova , Thomas Gleixner , Roman Gushchin , Andrea Arcangeli Al Viro List-Id: linux-api@vger.kernel.org On 10/14, Christian Brauner wrote: > > The child helper process on Linux posix_spawn must ensure that no signal > handlers are enabled, so the signal disposition must be either SIG_DFL > or SIG_IGN. However, it requires a sigprocmask to obtain the current > signal mask and at least _NSIG sigaction calls to reset the signal > handlers for each posix_spawn call Plus the caller has to block/unblock all signals around clone(VM|VFORK). Can this justify the new CLONE_ flag? Honestly, I have no idea. But the patch is simple and looks technically correct to me. FWIW, Reviewed-by: Oleg Nesterov