linux-api.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Minchan Kim <minchan@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	linux-mm <linux-mm@kvack.org>,
	linux-api@vger.kernel.org, oleksandr@redhat.com,
	Suren Baghdasaryan <surenb@google.com>,
	Tim Murray <timmurray@google.com>,
	Daniel Colascione <dancol@google.com>,
	Sandeep Patil <sspatil@google.com>,
	Sonny Rao <sonnyrao@google.com>,
	Brian Geffon <bgeffon@google.com>, Michal Hocko <mhocko@suse.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Shakeel Butt <shakeelb@google.com>,
	John Dias <joaodias@google.com>,
	ktkhai@virtuozzo.com, christian.brauner@ubuntu.com,
	sjpark@amazon.de, Minchan Kim <minchan@kernel.org>,
	Minchan Kim <minchan@google.com>
Subject: [PATCH v2 3/5] mm/madvise: employ mmget_still_valid for write lock
Date: Thu, 16 Jan 2020 15:59:51 -0800	[thread overview]
Message-ID: <20200116235953.163318-4-minchan@kernel.org> (raw)
In-Reply-To: <20200116235953.163318-1-minchan@kernel.org>

From: Oleksandr Natalenko <oleksandr@redhat.com>

Do the very same trick as we already do since 04f5866e41fb. KSM hints
will require locking mmap_sem for write since they modify vm_flags, so
for remote KSM hinting this additional check is needed.

Signed-off-by: Oleksandr Natalenko <oleksandr@redhat.com>
Signed-off-by: Minchan Kim <minchan@google.com>
---
 mm/madvise.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/mm/madvise.c b/mm/madvise.c
index 59b5cc99ef61..84cffd0900f1 100644
--- a/mm/madvise.c
+++ b/mm/madvise.c
@@ -1059,6 +1059,8 @@ static int madvise_common(struct task_struct *task, struct mm_struct *mm,
 	if (write) {
 		if (down_write_killable(&mm->mmap_sem))
 			return -EINTR;
+		if (current->mm != mm && !mmget_still_valid(mm))
+			goto skip_mm;
 	} else {
 		down_read(&mm->mmap_sem);
 	}
@@ -1109,6 +1111,7 @@ static int madvise_common(struct task_struct *task, struct mm_struct *mm,
 	}
 out:
 	blk_finish_plug(&plug);
+skip_mm:
 	if (write)
 		up_write(&mm->mmap_sem);
 	else
-- 
2.25.0.rc1.283.g88dfdc4193-goog

  parent reply	other threads:[~2020-01-16 23:59 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-16 23:59 [PATCH v2 0/5] introduce memory hinting API for external process Minchan Kim
2020-01-16 23:59 ` [PATCH v2 1/5] mm: factor out madvise's core functionality Minchan Kim
     [not found]   ` <20200116235953.163318-2-minchan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2020-01-17 10:02     ` Kirill Tkhai
     [not found]       ` <d3b8431d-fa3d-6a16-8af1-a68b3ac8ca58-5HdwGun5lf+gSpxsJD1C4w@public.gmane.org>
2020-01-17 18:14         ` Minchan Kim
     [not found] ` <20200116235953.163318-1-minchan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2020-01-16 23:59   ` [PATCH v2 2/5] mm: introduce external memory hinting API Minchan Kim
     [not found]     ` <20200116235953.163318-3-minchan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2020-01-17 11:52       ` Michal Hocko
     [not found]         ` <20200117115225.GV19428-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2020-01-17 15:58           ` Kirill A. Shutemov
2020-01-17 17:32             ` Minchan Kim
     [not found]               ` <20200117173239.GB140922-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2020-01-17 21:26                 ` Kirill A. Shutemov
2020-01-18  9:40                   ` SeongJae Park
2020-01-19 16:14                   ` sspatil-hpIqsD4AKlfQT0dZR+AlfA
2020-01-20  7:58                     ` Michal Hocko
     [not found]                       ` <20200120075825.GH18451-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2020-01-20 10:39                         ` Kirill Tkhai
2020-01-21 18:32                       ` Minchan Kim
     [not found]                         ` <20200121183212.GF140922-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2020-01-22  8:28                           ` Michal Hocko
     [not found]                             ` <20200122082853.GS29276-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2020-01-22  9:36                               ` SeongJae Park
     [not found]                                 ` <20200122093624.14799-1-sjpark-vV1OtcyAfmbQT0dZR+AlfA@public.gmane.org>
2020-01-22 10:02                                   ` Michal Hocko
     [not found]                                     ` <20200122100233.GT29276-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2020-01-22 13:28                                       ` SeongJae Park
2020-01-23  1:41                               ` Minchan Kim
2020-01-23  9:13                                 ` Michal Hocko
2020-01-21 18:11                   ` Minchan Kim
2020-01-22 10:44                     ` Oleksandr Natalenko
2020-01-23  1:43                       ` Minchan Kim
2020-01-23  7:29                         ` Oleksandr Natalenko
2020-01-17 17:25           ` Minchan Kim
     [not found]             ` <20200117172542.GA140922-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2020-01-20  8:03               ` Michal Hocko
2020-01-20 10:24           ` Kirill Tkhai
     [not found]             ` <f57fb198-4070-d3b4-b6bd-43b29ff40a2c-5HdwGun5lf+gSpxsJD1C4w@public.gmane.org>
2020-01-20 11:27               ` Michal Hocko
2020-01-20 12:39                 ` Kirill A. Shutemov
2020-01-20 13:24                   ` Michal Hocko
2020-01-20 14:21                     ` Kirill A. Shutemov
2020-01-20 15:44                       ` Michal Hocko
     [not found]                     ` <20200120132405.GF18451-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2020-01-21 18:43                       ` Minchan Kim
2020-01-16 23:59 ` Minchan Kim [this message]
2020-01-16 23:59 ` [PATCH v2 4/5] mm/madvise: allow KSM hints for remote API Minchan Kim
     [not found]   ` <20200116235953.163318-5-minchan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2020-01-17 10:13     ` Kirill Tkhai
     [not found]       ` <37338e14-5a55-1926-b6c1-5f98b6a6fdb5-5HdwGun5lf+gSpxsJD1C4w@public.gmane.org>
2020-01-17 12:34         ` Oleksandr Natalenko
     [not found]           ` <20200117123400.o3ne6kazkovq4okd-1pX4wqAwPg9Bd2nDH4ldLLp2dZbC/Bob@public.gmane.org>
2020-01-21 17:45             ` Minchan Kim
2020-01-16 23:59 ` [PATCH v2 5/5] mm: support both pid and pidfd for process_madvise Minchan Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200116235953.163318-4-minchan@kernel.org \
    --to=minchan@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=bgeffon@google.com \
    --cc=christian.brauner@ubuntu.com \
    --cc=dancol@google.com \
    --cc=hannes@cmpxchg.org \
    --cc=joaodias@google.com \
    --cc=ktkhai@virtuozzo.com \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=minchan@google.com \
    --cc=oleksandr@redhat.com \
    --cc=shakeelb@google.com \
    --cc=sjpark@amazon.de \
    --cc=sonnyrao@google.com \
    --cc=sspatil@google.com \
    --cc=surenb@google.com \
    --cc=timmurray@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).