From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Theodore Y. Ts'o" Subject: Re: [PATCH] fscrypt: reserve flags for hardware-wrapped keys feature Date: Fri, 17 Jan 2020 11:40:54 -0500 Message-ID: <20200117164054.GD448999@mit.edu> References: <20200116192008.35766-1-ebiggers@kernel.org> <20200117081246.GA16846@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20200117081246.GA16846@infradead.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+gldm-linux-mtd-36=m.gmane-mx.org@lists.infradead.org To: Christoph Hellwig Cc: Barani Muthukumaran , Gaurav Kashyap , linux-api@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Eric Biggers , linux-fscrypt@vger.kernel.org, linux-mtd@lists.infradead.org, Jaegeuk Kim , linux-ext4@vger.kernel.org List-Id: linux-api@vger.kernel.org On Fri, Jan 17, 2020 at 12:12:46AM -0800, Christoph Hellwig wrote: > On Thu, Jan 16, 2020 at 11:20:08AM -0800, Eric Biggers wrote: > > From: Eric Biggers > > > > Reserve flags for the hardware-wrapped keys feature which is being > > worked on [1]. FSCRYPT_POLICY_FLAG_HW_WRAPPED_KEY will denote that the > > encryption policy needs a hardware-wrapped key to be unlocked. > > FSCRYPT_ADD_KEY_FLAG_HW_WRAPPED will denote that the key being added is > > a hardware-wrapped key. > > > > This reservation is tentative, and these codepoints may be reused if the > > feature is not upstreamed. > > NAK. While the feature itself sounds really useful we don't just > reserve format bits for code not upstream. I disagree; saving a codepoint to avoid accidental collision of a feature bit is a good and proper thing to do. Reviewed-by: Theodore Ts'o - Ted ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/