From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Kirill A. Shutemov" Subject: Re: [PATCH v2] mm: Add MREMAP_DONTUNMAP to mremap(). Date: Mon, 3 Feb 2020 16:09:40 +0300 Message-ID: <20200203130940.enfvdsbn42hhoaki@box> References: <20200123014627.71720-1-bgeffon@google.com> <20200124190625.257659-1-bgeffon@google.com> <20200126220650.i4lwljpvohpgvsi2@box> <20200129104655.egvpavc2tzozlbqe@box> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Brian Geffon Cc: Andrew Morton , "Michael S . Tsirkin" , Arnd Bergmann , LKML , linux-mm , linux-api@vger.kernel.org, Andy Lutomirski , Andrea Arcangeli , Sonny Rao , Minchan Kim , Joel Fernandes , Yu Zhao , Jesse Barnes List-Id: linux-api@vger.kernel.org On Sun, Feb 02, 2020 at 05:17:53AM +0100, Brian Geffon wrote: > On Wed, Jan 29, 2020 at 11:46 AM Kirill A. Shutemov > wrote: > > Any better options for the flag name? (I have none) > > The other option is that it's broken up into two new flags the first > MREMAP_MUSTMOVE which can be used regardless of whether or not you're > leaving the original mapping mapped. This would do exactly what it > describes: move the mapping to a new address with or without > MREMAP_FIXED, this keeps consistency with MAYMOVE. > > The second flag would be the new MREMAP_DONTUNMAP flag which requires > MREMAP_MUSTMOVE, again with or without MREMAP_FIXED. > > What are your thoughts on this? Sounds reasonable. MREMAP_DONTUNMAP doesn't really convey that you move pages to the new mapping, but leave empty mapping behind. But I guess there's only so much you can encode into the name. (Patch to the man page should do the rest) -- Kirill A. Shutemov