linux-api.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Colascione <dancol-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
To: dancol-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
	timmurray-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
	nosh-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
	nnk-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
	lokeshgidra-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	selinux-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH v2 4/6] Wire UFFD up to SELinux
Date: Tue, 11 Feb 2020 14:55:45 -0800	[thread overview]
Message-ID: <20200211225547.235083-5-dancol@google.com> (raw)
In-Reply-To: <20200211225547.235083-1-dancol-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>

This change gives userfaultfd file descriptors a real security
context, allowing policy to act on them.

Signed-off-by: Daniel Colascione <dancol-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
---
 fs/userfaultfd.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/fs/userfaultfd.c b/fs/userfaultfd.c
index 07b0f6e03849..11227b94a5a7 100644
--- a/fs/userfaultfd.c
+++ b/fs/userfaultfd.c
@@ -1020,6 +1020,8 @@ static int resolve_userfault_fork(struct userfaultfd_ctx *ctx,
 {
 	int fd;
 
+	/* Regular inode here is okay: only CAP_SYS_PTRACE callers
+	 * can monitor forks.  */
 	fd = anon_inode_getfd("[userfaultfd]", &userfaultfd_fops, new,
 			      O_RDWR | (new->flags & UFFD_SHARED_FCNTL_FLAGS));
 	if (fd < 0)
@@ -1972,8 +1974,9 @@ SYSCALL_DEFINE1(userfaultfd, int, flags)
 	/* prevent the mm struct to be freed */
 	mmgrab(ctx->mm);
 
-	fd = anon_inode_getfd("[userfaultfd]", &userfaultfd_fops, ctx,
-			      O_RDWR | (flags & UFFD_SHARED_FCNTL_FLAGS));
+	fd = anon_inode_getfd2("[userfaultfd]", &userfaultfd_fops, ctx,
+			       O_RDWR | (flags & UFFD_SHARED_FCNTL_FLAGS),
+			       ANON_INODE_SECURE);
 	if (fd < 0) {
 		mmdrop(ctx->mm);
 		kmem_cache_free(userfaultfd_ctx_cachep, ctx);
-- 
2.25.0.225.g125e21ebc7-goog

  parent reply	other threads:[~2020-02-11 22:55 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-11 22:55 [PATCH v2 0/6] Harden userfaultfd Daniel Colascione
2020-02-11 22:55 ` [PATCH v2 1/6] Add a new flags-accepting interface for anonymous inodes Daniel Colascione
2020-02-12 16:37   ` Stephen Smalley
     [not found]     ` <88ea16bd-38be-b4f9-dfb3-e0626f5b6aaf-+05T5uksL2qpZYMLLGbcSA@public.gmane.org>
2020-02-12 17:23       ` Daniel Colascione
2020-02-11 22:55 ` [PATCH v2 2/6] Add a concept of a "secure" anonymous file Daniel Colascione
2020-02-12 16:49   ` Stephen Smalley
2020-02-14 22:13   ` kbuild test robot
2020-02-11 22:55 ` [PATCH v2 3/6] Teach SELinux about a new userfaultfd class Daniel Colascione
2020-02-12 17:05   ` Stephen Smalley
2020-02-12 17:19     ` Daniel Colascione
     [not found]       ` <CAKOZuesUVSYJ6EjHFL3QyiWKVmyhm1fLp5Bm_SHjB3_s1gn08A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-02-12 18:04         ` Stephen Smalley
2020-02-12 18:59           ` Stephen Smalley
     [not found]             ` <69f4ccce-18b2-42c1-71ac-3fe9caf2dfb6-+05T5uksL2qpZYMLLGbcSA@public.gmane.org>
2020-02-12 19:04               ` Daniel Colascione
     [not found]                 ` <CAKOZuevoKDYGVSooWAhi7Jr6Ww-+NEd-sStaPcN5Q6g+NKKRPQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-02-12 19:11                   ` Stephen Smalley
     [not found]                     ` <626a2302-5b5f-d7c1-fdef-51094bb1fe0d-+05T5uksL2qpZYMLLGbcSA@public.gmane.org>
2020-02-12 19:13                       ` Daniel Colascione
2020-02-12 19:17                     ` Stephen Smalley
2020-02-11 22:55 ` [PATCH v2 6/6] Add a new sysctl for limiting userfaultfd to user mode faults Daniel Colascione
     [not found] ` <20200211225547.235083-1-dancol-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2020-02-11 22:55   ` Daniel Colascione [this message]
2020-02-11 22:55   ` [PATCH v2 5/6] Let userfaultfd opt out of handling kernel-mode faults Daniel Colascione
2020-02-11 23:13   ` [PATCH v2 0/6] Harden userfaultfd Casey Schaufler
2020-02-11 23:27     ` Daniel Colascione
2020-02-12 16:09       ` Stephen Smalley
2020-02-21 17:56       ` James Morris
2020-02-12  7:50   ` Kees Cook
2020-02-12 16:54     ` Jann Horn
2020-02-12 17:14       ` Peter Xu
2020-02-12 19:41         ` Andrea Arcangeli
2020-02-12 20:04           ` Daniel Colascione
2020-02-12 23:41             ` Andrea Arcangeli
2020-02-12 17:12     ` Daniel Colascione

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200211225547.235083-5-dancol@google.com \
    --to=dancol-hpiqsd4aklfqt0dzr+alfa@public.gmane.org \
    --cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=lokeshgidra-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    --cc=nnk-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    --cc=nosh-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    --cc=selinux-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=timmurray-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).