From: kbuild test robot <lkp@intel.com>
To: Daniel Colascione <dancol@google.com>
Cc: kbuild-all@lists.01.org, dancol@google.com, timmurray@google.com,
nosh@google.com, nnk@google.com, lokeshgidra@google.com,
linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
selinux@vger.kernel.org
Subject: Re: [PATCH v2 2/6] Add a concept of a "secure" anonymous file
Date: Sat, 15 Feb 2020 06:13:47 +0800 [thread overview]
Message-ID: <202002150657.5YrE7Byp%lkp@intel.com> (raw)
In-Reply-To: <20200211225547.235083-3-dancol@google.com>
[-- Attachment #1: Type: text/plain, Size: 2082 bytes --]
Hi Daniel,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on pcmoore-selinux/next]
[also build test ERROR on security/next-testing linux/master linus/master v5.6-rc1 next-20200214]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Daniel-Colascione/Harden-userfaultfd/20200215-034039
base: https://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/selinux.git next
config: i386-tinyconfig (attached as .config)
compiler: gcc-7 (Debian 7.5.0-4) 7.5.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
fs/anon_inodes.c: In function 'anon_inode_make_secure_inode':
>> fs/anon_inodes.c:67:10: error: implicit declaration of function 'security_inode_init_security_anon'; did you mean 'security_inode_init_security'? [-Werror=implicit-function-declaration]
error = security_inode_init_security_anon(inode, name, fops);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
security_inode_init_security
cc1: some warnings being treated as errors
vim +67 fs/anon_inodes.c
57
58 struct inode *anon_inode_make_secure_inode(const char *name,
59 const struct file_operations *fops)
60 {
61 struct inode *inode;
62 int error;
63 inode = alloc_anon_inode(anon_inode_mnt->mnt_sb);
64 if (IS_ERR(inode))
65 return ERR_PTR(PTR_ERR(inode));
66 inode->i_flags &= ~S_PRIVATE;
> 67 error = security_inode_init_security_anon(inode, name, fops);
68 if (error) {
69 iput(inode);
70 return ERR_PTR(error);
71 }
72 return inode;
73 }
74
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 7239 bytes --]
next prev parent reply other threads:[~2020-02-14 22:13 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 22:55 [PATCH v2 0/6] Harden userfaultfd Daniel Colascione
2020-02-11 22:55 ` [PATCH v2 1/6] Add a new flags-accepting interface for anonymous inodes Daniel Colascione
2020-02-12 16:37 ` Stephen Smalley
[not found] ` <88ea16bd-38be-b4f9-dfb3-e0626f5b6aaf-+05T5uksL2qpZYMLLGbcSA@public.gmane.org>
2020-02-12 17:23 ` Daniel Colascione
2020-02-11 22:55 ` [PATCH v2 2/6] Add a concept of a "secure" anonymous file Daniel Colascione
2020-02-12 16:49 ` Stephen Smalley
2020-02-14 22:13 ` kbuild test robot [this message]
2020-02-11 22:55 ` [PATCH v2 3/6] Teach SELinux about a new userfaultfd class Daniel Colascione
2020-02-12 17:05 ` Stephen Smalley
2020-02-12 17:19 ` Daniel Colascione
[not found] ` <CAKOZuesUVSYJ6EjHFL3QyiWKVmyhm1fLp5Bm_SHjB3_s1gn08A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-02-12 18:04 ` Stephen Smalley
2020-02-12 18:59 ` Stephen Smalley
[not found] ` <69f4ccce-18b2-42c1-71ac-3fe9caf2dfb6-+05T5uksL2qpZYMLLGbcSA@public.gmane.org>
2020-02-12 19:04 ` Daniel Colascione
[not found] ` <CAKOZuevoKDYGVSooWAhi7Jr6Ww-+NEd-sStaPcN5Q6g+NKKRPQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-02-12 19:11 ` Stephen Smalley
[not found] ` <626a2302-5b5f-d7c1-fdef-51094bb1fe0d-+05T5uksL2qpZYMLLGbcSA@public.gmane.org>
2020-02-12 19:13 ` Daniel Colascione
2020-02-12 19:17 ` Stephen Smalley
2020-02-11 22:55 ` [PATCH v2 6/6] Add a new sysctl for limiting userfaultfd to user mode faults Daniel Colascione
[not found] ` <20200211225547.235083-1-dancol-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2020-02-11 22:55 ` [PATCH v2 4/6] Wire UFFD up to SELinux Daniel Colascione
2020-02-11 22:55 ` [PATCH v2 5/6] Let userfaultfd opt out of handling kernel-mode faults Daniel Colascione
2020-02-11 23:13 ` [PATCH v2 0/6] Harden userfaultfd Casey Schaufler
2020-02-11 23:27 ` Daniel Colascione
2020-02-12 16:09 ` Stephen Smalley
2020-02-21 17:56 ` James Morris
2020-02-12 7:50 ` Kees Cook
2020-02-12 16:54 ` Jann Horn
2020-02-12 17:14 ` Peter Xu
2020-02-12 19:41 ` Andrea Arcangeli
2020-02-12 20:04 ` Daniel Colascione
2020-02-12 23:41 ` Andrea Arcangeli
2020-02-12 17:12 ` Daniel Colascione
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202002150657.5YrE7Byp%lkp@intel.com \
--to=lkp@intel.com \
--cc=dancol@google.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lokeshgidra@google.com \
--cc=nnk@google.com \
--cc=nosh@google.com \
--cc=selinux@vger.kernel.org \
--cc=timmurray@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).