From: Michal Hocko <mhocko@kernel.org>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Luis Chamberlain <mcgrof@kernel.org>,
Kees Cook <keescook@chromium.org>,
Iurii Zaikin <yzaikin@google.com>,
linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
linux-mm@kvack.org, Ivan Teterevkov <ivan.teterevkov@nutanix.com>,
David Rientjes <rientjes@google.com>,
Matthew Wilcox <willy@infradead.org>,
"Eric W . Biederman" <ebiederm@xmission.com>,
"Guilherme G . Piccoli" <gpiccoli@canonical.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Christian Brauner <christian.brauner@ubuntu.com>
Subject: Re: [PATCH v2 0/3] support setting sysctl parameters from kernel command line
Date: Wed, 15 Apr 2020 12:01:46 +0200 [thread overview]
Message-ID: <20200415100146.GC4629@dhcp22.suse.cz> (raw)
In-Reply-To: <3fc1303a-cb57-b96e-ce77-7ff6407ab538@suse.cz>
On Wed 15-04-20 10:56:35, Vlastimil Babka wrote:
> On 4/15/20 5:23 AM, Masami Hiramatsu wrote:
> > Hi Vlastimil,
> >
> > On Tue, 14 Apr 2020 13:32:19 +0200
> > Vlastimil Babka <vbabka@suse.cz> wrote:
> >
> >> This series adds support for something that seems like many people always
> >> wanted but nobody added it yet, so here's the ability to set sysctl parameters
> >> via kernel command line options in the form of sysctl.vm.something=1
> >
> > Sounds good. And would you consider to use the bootconfig instead of (or
> > in addition to) the kernel command line, because it is too short to describe
> > the sysctl options?
>
> "Instead of" - no, as that would defeat the scenario of "I just want to set this
> one sysctl in grub (possibly interactively) and not update initrd for that". If
> constructing bootconfig is of similar effort of loading sysctl.conf from initrd,
> then I see little benefit?
>
> "in addition to" - sure! but I hoped that's what already happens as it seemed to
> me that options from bootconfig are appended to the command line that's then
> parsed by everyone else, no? But I'll try it to be sure.
Completely agreed!
Btw. patches look sensible to me so feel free to add
Acked-by: Michal Hocko <mhocko@suse.com>
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2020-04-15 10:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 11:32 [PATCH v2 0/3] support setting sysctl parameters from kernel command line Vlastimil Babka
2020-04-14 11:32 ` [PATCH v2 1/3] kernel/sysctl: " Vlastimil Babka
2020-04-15 3:08 ` Kees Cook
2020-04-15 9:03 ` Masami Hiramatsu
2020-04-16 1:29 ` Luis Chamberlain
2020-04-16 10:49 ` Masami Hiramatsu
2020-04-16 15:53 ` Luis Chamberlain
2020-04-17 10:34 ` Masami Hiramatsu
2020-04-17 16:59 ` Luis Chamberlain
2020-04-18 10:12 ` Masami Hiramatsu
2020-04-14 11:32 ` [PATCH v2 2/3] kernel/sysctl: support handling command line aliases Vlastimil Babka
2020-04-14 11:32 ` [PATCH v2 3/3] kernel/hung_task convert hung_task_panic boot parameter to sysctl Vlastimil Babka
2020-04-15 3:23 ` [PATCH v2 0/3] support setting sysctl parameters from kernel command line Masami Hiramatsu
2020-04-15 6:30 ` Luis Chamberlain
2020-04-16 6:02 ` Masami Hiramatsu
2020-04-16 6:38 ` Luis Chamberlain
2020-04-15 8:56 ` Vlastimil Babka
2020-04-15 10:01 ` Michal Hocko [this message]
2020-04-16 6:08 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200415100146.GC4629@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=christian.brauner@ubuntu.com \
--cc=ebiederm@xmission.com \
--cc=gpiccoli@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=ivan.teterevkov@nutanix.com \
--cc=keescook@chromium.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcgrof@kernel.org \
--cc=mhiramat@kernel.org \
--cc=rientjes@google.com \
--cc=tglx@linutronix.de \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).