From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BE9BC54FCB for ; Wed, 22 Apr 2020 16:34:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6A9DA21473 for ; Wed, 22 Apr 2020 16:34:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587573296; bh=w4JN5T5oaZgQeBhYVqmXSSTzkWYLzuJOyQMklh0w+mc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=bi4tvCx0jjCQsQQisL4mWPKTngAf7Qe0oPZRYQ8KvL5eDYB4RJ23mwGoj3+PWFvjy mY5hUUpZquefNz455Z2dC5OIujwnuF9rXg3INi7lGBREKiPNCJGNVD5FUjRSvt9HTl e0V0t7C7wdlNePxKtQw0eoHQ7dwaIEodtnNZnu4U= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726337AbgDVQe4 (ORCPT ); Wed, 22 Apr 2020 12:34:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:45550 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725808AbgDVQez (ORCPT ); Wed, 22 Apr 2020 12:34:55 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EC2C42082E; Wed, 22 Apr 2020 16:34:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587573295; bh=w4JN5T5oaZgQeBhYVqmXSSTzkWYLzuJOyQMklh0w+mc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aZf1+a1hml5uJnZaaGENlJlwC+gD2DiStpvw9MbJN79Of1MS4pCvEtSRkFH8HgEAs 7fOVd35T+0Gzr+lcs/fPBzcOfZwgU1mtNIXUpTpq/zVTT1FP1lqMBaln4BIhmCMnnX BYRK3509URKr1fwMf23OLyAXB9dtNLLPLUEV5wns= Date: Wed, 22 Apr 2020 18:34:53 +0200 From: Greg Kroah-Hartman To: Christian Brauner Cc: Jens Axboe , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-api@vger.kernel.org, Jonathan Corbet , Serge Hallyn , "Rafael J. Wysocki" , Tejun Heo , "David S. Miller" , Saravana Kannan , Jan Kara , David Howells , Seth Forshee , David Rheinsberg , Tom Gundersen , Christian Kellner , Dmitry Vyukov , =?iso-8859-1?Q?St=E9phane?= Graber , linux-doc@vger.kernel.org, netdev@vger.kernel.org, Steve Barber , Dylan Reid , Filipe Brandenburger , Kees Cook , Benjamin Elder , Akihiro Suda Subject: Re: [PATCH v2 1/7] kobject_uevent: remove unneeded netlink_ns check Message-ID: <20200422163453.GA3438121@kroah.com> References: <20200422145437.176057-1-christian.brauner@ubuntu.com> <20200422145437.176057-2-christian.brauner@ubuntu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200422145437.176057-2-christian.brauner@ubuntu.com> Sender: linux-api-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-api@vger.kernel.org On Wed, Apr 22, 2020 at 04:54:31PM +0200, Christian Brauner wrote: > Back when I rewrote large chunks of uevent sending I should have removed > the .netlink_ns method completely after having removed it's last user in > [1]. Let's remove it now and also remove the helper associated with it > that is unused too. > > Fixes: a3498436b3a0 ("netns: restrict uevents") /* No backport needed. */ > Cc: Greg Kroah-Hartman > Cc: "David S. Miller" > Signed-off-by: Christian Brauner Reviewed-by: Greg Kroah-Hartman