From: Al Viro <viro@zeniv.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linux API <linux-api@vger.kernel.org>
Subject: Re: [RFC] unexport linux/elfcore.h
Date: Thu, 11 Jun 2020 22:35:30 +0100 [thread overview]
Message-ID: <20200611213530.GB23230@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CAHk-=wijbWCfZaiYO68MSfxz-UMuJCuO1Sr9O1x4BTPpMjm4gw@mail.gmail.com>
On Thu, Jun 11, 2020 at 01:01:40PM -0700, Linus Torvalds wrote:
> On Thu, Jun 11, 2020 at 8:23 AM Al Viro <viro@zeniv.linux.org.uk> wrote:
> >
> > I mean something like this. Objections?
>
> I'm not seeing that alot of people would care.
>
> That said, is there any reason not to try to fix it instead and expose
> elf_gregset_t some way?
>
> But I do suspect it all really boils down to "nobody cares". If you
> can't find somebody to speak up for it, might as well remove it.
Anyone who wants to use that stuff includes sys/procfs.h anyway (since
1996). As for the reasons... I would love to kill off these gems, for
example:
#define PRSTATUS_SIZE(S, R) (R != sizeof(S.pr_reg) ? 144 : 296)
#define SET_PR_FPVALID(S, V, R) \
do { *(int *) (((void *) &((S)->pr_reg)) + R) = (V); } \
while (0)
(x86 asm/compat.h) And being able to massage the definition of
elf_prstatus (while keeping the size and layout - it describes
a part of file format, after all) would simplify the life alot.
struct __kernel_elf_prstatus would be an obvious solution, but...
nobody in userland pulls the definition in linux/elfcore.h and
hadn't been able to do that for at least a decade (if not more than
that). So I'd rather get rid of exporting it.
prev parent reply other threads:[~2020-06-11 21:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 1:01 [RFC] unexport linux/elfcore.h Al Viro
2020-06-11 15:23 ` Al Viro
2020-06-11 20:01 ` Linus Torvalds
2020-06-11 21:35 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200611213530.GB23230@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-api@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).