From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA512C4727C for ; Mon, 21 Sep 2020 22:52:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AD57F23A74 for ; Mon, 21 Sep 2020 22:52:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728379AbgIUWwz (ORCPT ); Mon, 21 Sep 2020 18:52:55 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:56940 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726913AbgIUWwy (ORCPT ); Mon, 21 Sep 2020 18:52:54 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id D6A341C0B8C; Tue, 22 Sep 2020 00:52:51 +0200 (CEST) Date: Tue, 22 Sep 2020 00:52:51 +0200 From: Pavel Machek To: Dave Hansen Cc: "Yu, Yu-cheng" , Randy Dunlap , x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Peter Zijlstra , "Ravi V. Shankar" , Vedvyas Shanbhogue , Dave Martin , Weijiang Yang Subject: Re: [PATCH v12 1/8] x86/cet/ibt: Add Kconfig option for user-mode Indirect Branch Tracking Message-ID: <20200921225251.GB13299@amd> References: <20200918192312.25978-1-yu-cheng.yu@intel.com> <20200918192312.25978-2-yu-cheng.yu@intel.com> <20200918205933.GB4304@duo.ucw.cz> <019b5e45-b116-7f3d-f1f2-3680afbd676c@intel.com> <20200918214020.GF4304@duo.ucw.cz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="vGgW1X5XWziG23Ko" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-api@vger.kernel.org --vGgW1X5XWziG23Ko Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > > +config X86_INTEL_BRANCH_TRACKING_USER > > + prompt "Intel Indirect Branch Tracking for user-mode"=20 >=20 > Take the "Intel " and "INTEL_" out, please. It will only cause us all > pain later if some of our x86 compatriots decide to implement this. Are other x86 manufacturers legally allowed to implement that? > > If the kernel is to be used only on older systems that do not support > > IBT, and the size of the binary is important, you can save 900 KB by > > disabling this feature. > >=20 > > Otherwise, if unsure, say Y. >=20 > 900k seems like a *lot*. Where the heck does that come from? >=20 > Also, comments like that don't age very well. Consider: >=20 > Support for this feature is only known to be present on Intel > processors released in 2020 or later. This feature is also > known to increase kernel text size substantially. >=20 > If unsure, say N. That is much better, thanks. Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --vGgW1X5XWziG23Ko Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAl9pLsMACgkQMOfwapXb+vJrcACfdEe0RXB3Ob0O3qo7vS+3J9EX tmQAoMBivI2SYhK1uaQoHu+xCvzD3BHu =QpK9 -----END PGP SIGNATURE----- --vGgW1X5XWziG23Ko--