From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7308EC4727D for ; Tue, 22 Sep 2020 19:37:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 33564238D6 for ; Tue, 22 Sep 2020 19:37:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="fEKFgp4I" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726637AbgIVThE (ORCPT ); Tue, 22 Sep 2020 15:37:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56796 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726448AbgIVThE (ORCPT ); Tue, 22 Sep 2020 15:37:04 -0400 Received: from mail-pj1-x1041.google.com (mail-pj1-x1041.google.com [IPv6:2607:f8b0:4864:20::1041]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4DBBDC0613CF for ; Tue, 22 Sep 2020 12:37:04 -0700 (PDT) Received: by mail-pj1-x1041.google.com with SMTP id s14so1635232pju.1 for ; Tue, 22 Sep 2020 12:37:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=VoNsN4gNoyVIa9dngp5daYP4L9xdQNJFl/CtG0+h+Ss=; b=fEKFgp4I7N40Nzy6tgs8G5ZG/FVMRNy9LK/zAR9yCffVDCzwFkpclAKN7CrCo6SnuB Mhwrh3TYxcXCS86vuzMWkG/ZoaLgqPC1SYRA26QUSKPHIKKdhBrPaAHOqiC7zeUOIGtN 6iW/8+otolDASDMvHpUoLjZbgqkXBbxL5oPHk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=VoNsN4gNoyVIa9dngp5daYP4L9xdQNJFl/CtG0+h+Ss=; b=IsWC6Rzzq9yiDpcuExf2M+duS0j9ylluScjdsxmmBIdDabN+Pd5sPwdvRx2XpGDWve aKcjcYq2z5isic//OWKV226RZBC7O9TDaZu7jP0M1duT6DJuKdwCt7X9JZeXnteF6nb5 8H6yVoQhGJcnkd+SeDRm+toiffd+3vZikSeAPD7QfRUqzKAMpcEivbc4m4+la6isboyh U/1/fPeGZ6Nwco64JH1lP6SpuZwdl6YDMFNTmbLwRGXkWGL5ph72KXNyRWghtHuY4y93 7z1Xta3cZ5j1fxOaRTx/+/pAj9teBAv4oMJ5/0xlRFcOCW9QBfEGTN4OCq9Pe6/oh6cl 9Stw== X-Gm-Message-State: AOAM53079BYLWBymYVcLDcqPokdjuBGlsr2pjMRb6XRNIAKZxg/PZvdh qhP7JJ0w+cDwzAN45GO1vmMz9g== X-Google-Smtp-Source: ABdhPJwEqJBLbphcxoGt9HBYC6vR4ITJyo7LLBwP2ueoi8PvC6MRmbBII6r/yQBmxozFJ3zpnA7KNA== X-Received: by 2002:a17:90b:4ac2:: with SMTP id mh2mr202994pjb.210.1600803423915; Tue, 22 Sep 2020 12:37:03 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id d6sm3319328pjw.0.2020.09.22.12.37.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Sep 2020 12:37:03 -0700 (PDT) Date: Tue, 22 Sep 2020 12:37:02 -0700 From: Kees Cook To: Gabriel Krisman Bertazi Cc: luto@kernel.org, tglx@linutronix.de, x86@kernel.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, willy@infradead.org, linux-kselftest@vger.kernel.org, shuah@kernel.org, kernel@collabora.com Subject: Re: [PATCH v6 7/9] x86: Enable Syscall User Dispatch Message-ID: <202009221236.04AA334C2@keescook> References: <20200904203147.2908430-1-krisman@collabora.com> <20200904203147.2908430-8-krisman@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200904203147.2908430-8-krisman@collabora.com> Precedence: bulk List-ID: X-Mailing-List: linux-api@vger.kernel.org On Fri, Sep 04, 2020 at 04:31:45PM -0400, Gabriel Krisman Bertazi wrote: > Syscall User Dispatch requirements are fully supported in x86. This > patch flips the switch, marking it as supported. This was tested > against Syscall User Dispatch selftest. > > Signed-off-by: Gabriel Krisman Bertazi > --- > arch/x86/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index 7101ac64bb20..56ac8de99021 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -150,6 +150,7 @@ config X86 > select HAVE_ARCH_COMPAT_MMAP_BASES if MMU && COMPAT > select HAVE_ARCH_PREL32_RELOCATIONS > select HAVE_ARCH_SECCOMP_FILTER > + select HAVE_ARCH_SYSCALL_USER_DISPATCH Is this needed at all? I think simply "the architecture uses the generic entry code" is sufficient to enable it. (Especially since there's a top level config for SYSCALL_USER_DISPATCH, it feels like overkill). -- Kees Cook